feat(checks): accept model strings in set_default_generator - #2794
Merged
Conversation
Allow set_default_generator to take a model identifier string and wrap it in Generator, so callers no longer need a separate giskard.agents import for the common case. Co-authored-by: henrique <henrique@giskard.ai>
giskard-checks may only import giskard.agents from the package root, so string overloads reuse the existing Generator import instead of giskard.agents.generators. Co-authored-by: henrique <henrique@giskard.ai>
henchaves
marked this pull request as ready for review
August 25, 2026 14:57
Sync THIRD_PARTY_NOTICES.md with make generate-notices so check-notices matches the current licensecheck output. Co-authored-by: henrique <henrique@giskard.ai>
kevinmessiaen
approved these changes
Aug 26, 2026
Keep boto3/botocore 1.43.80 from main; the PR notices bump to 1.43.79 is superseded. Co-authored-by: Kevin Messiaen <kevinmessiaen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
set_default_generatornow accepts a model identifier string as well as aBaseGeneratorinstance. A string is wrapped ingiskard.agents.Generator, so the common case no longer needs a separate import:Passing a generator instance is unchanged, including identity:
The string is converted with the existing
giskard.agents.Generatorimport. A lazyfrom giskard.agents.generators import Generatoris not used becausegiskard-checksmay only import that library from the package root.Also regenerates
THIRD_PARTY_NOTICES.md(boto3/botocore1.43.78 → 1.43.79) somake check-noticesmatches currentlicensecheckoutput.Related Issue
N/A — requested as an API convenience.
Type of Change
Coding agents
Autonomous agents with no human in the loop must read AUTONOMOUS.md before opening a PR.
PR title: agent-opened PRs must end the title with
🤖🤖🤖🤖(exactly four robot emojis). Do not omit — that suffix is how the expedited agent PR workflow picks up the PR.Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.uv.lockrunninguv lock(only applicable whenpyproject.tomlhas been modified)