Skip to content

fix(agents): preserve api_base generation parameter #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikemikimike wants to merge 3 commits into from
Closed

fix(agents): preserve api_base generation parameter #2803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1914e5d
fix(agents): preserve api_base generation parameter
mikemikimike Aug 26, 2026
d792df8
Merge branch 'main' into fix/generation-params-unsupported-fields
mikemikimike Aug 27, 2026
b5d63e0
Merge branch 'main' into fix/generation-params-unsupported-fields
mikemikimike Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libs/giskard-agents/src/giskard/agents/generators/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,16 @@ class GenerationParams(BaseModel):
List of tools available to the model.
timeout : float | int | None, optional
Maximum time in seconds to wait for the completion request.
api_base : str | None, optional
Base URL for OpenAI-compatible completion endpoints.
"""

temperature: float = Field(default=1.0)
max_tokens: int | None = Field(default=None)
response_format: type[BaseModel] | None = Field(default=None)
tools: list[Tool] = Field(default_factory=list)
timeout: float | int | None = Field(default=None)
api_base: str | None = Field(default=None)

def merge(self, overrides: "GenerationParams | None") -> "GenerationParams":
"""Return a copy with *overrides*' explicitly-set fields applied on top.
Expand Down
10 changes: 10 additions & 0 deletions libs/giskard-agents/tests/test_litellm_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,16 @@ async def test_litellm_generator_forwards_params(mock_acompletion: Any) -> None:
assert kwargs["max_tokens"] == 50


async def test_litellm_generator_forwards_api_base(mock_acompletion: Any) -> None:
"""Custom OpenAI-compatible endpoints survive params serialization."""
generator = LiteLLMGenerator(model="openai/test-model").with_params(
api_base="http://127.0.0.1:1234/v1"
)
await generator.complete(messages=_USER_MESSAGE)

assert mock_acompletion.call_args.kwargs["api_base"] == "http://127.0.0.1:1234/v1"


async def test_litellm_generator_sanitizes_response_format_schema_name(
mock_acompletion: Any,
) -> None:
Expand Down
Loading