Skip to content

Commit da57fe2

Browse files
felickzCopilot
andauthored
docs(csharp): fix stale comment on codeql/csharp-queries dependency (#211)
The comment claimed this dependency was 'Required for Dependencies.ql', but that stopped being true in commit 8913c63 (Jan 2025), which switched Dependencies.ql's import from the queries-pack-only 'Telemetry.ExternalApi' to 'semmle.code.csharp.telemetry.ExternalApi', which ships in codeql/csharp-all. The dependency is still required, but for a different reason: suites/csharp-audit.qls and suites/csharp-external-api.qls both pull the upstream cs/untrusted-data-to-external-api query 'from: codeql/csharp-queries', which only lives in the queries pack, not csharp-all. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e78d3f00-2ea0-459b-86a2-91adc0e31c50
1 parent 57e36ec commit da57fe2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎csharp/src/qlpack.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ suites: suites
55
defaultSuiteFile: suites/csharp.qls
66
dependencies:
77
codeql/csharp-all: "7.1.0"
8-
codeql/csharp-queries: "1.8.0" # Required for Dependencies.ql
8+
codeql/csharp-queries: "1.8.0" # Required by suites/csharp-audit.qls and suites/csharp-external-api.qls for upstream cs/untrusted-data-to-external-api
99
githubsecuritylab/codeql-csharp-libs: "*"

0 commit comments

Comments
 (0)