Skip to content

fix duplicate python SQL injection audit query ID - #246

Merged
felickz merged 1 commit into
GitHubSecurityLab:mainfrom
tvharini9:fix-python-sql-injection-query-id
Nov 3, 2026
Merged

felickz merged 1 commit into
GitHubSecurityLab:mainfrom
tvharini9:fix-python-sql-injection-query-id

Conversation

@tvharini9

Copy link
Copy Markdown
Contributor

Summary

Fixes a duplicate query ID in the Python SQL injection audit queries.

Both SqlInjectionAudit.ql and SqlInjectionHeuristic.ql previously used:

githubsecuritylab/audit/sql-injection

The heuristic query now uses the unique ID:

githubsecuritylab/audit/sql-injection-heuristic

Background

The duplicate IDs were introduced in commit 9edecfb (Rename query IDs), which assigned the same replacement ID to both queries.

Changes

  • Updated the @id metadata in SqlInjectionHeuristic.ql.
  • Left query logic, severity, precision and tags unchanged.

Validation

  • Heuristic query compilation: passed.
  • Existing CWE-089 SQL injection audit test: passed (1/1).
  • Python query ID scan: no duplicate IDs found.
  • git diff --check: passed.

Only one query metadata line was changed.

@tvharini9

tvharini9 commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor Author

hi! This PR is ready for review. I've validated the heuristic query compilation and the existing CWE-089 audit test locally (1/1 passed).

I noticed the required CI checks are still waiting for status reports. Could a maintainer please check whether the workflow run needs approval and review the PR when convenient?

thank you

@felickz
felickz requested an auto review from Copilot November 3, 2026 01:14
@felickz

felickz commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution!

@felickz felickz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: 👍

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The duplicate CodeQL query ID has been replaced with a unique identifier, with the query logic and metadata otherwise preserved and no active review issues remaining.

No open issues 🎉

What changed in this PR

This pull request fixes a duplicate CodeQL query ID in the Python SQL injection audit queries by assigning the heuristic query a unique identifier.

Changes:

  • Changed the heuristic query ID to githubsecuritylab/audit/sql-injection-heuristic.
  • Preserved the query logic, severity, precision, and tags.
  • Confirmed the Python audit queries no longer contain duplicate IDs.
File Description
python/​src/​audit/​CWE-089/​SqlInjectionHeuristic.ql Updates the heuristic query’s @id metadata to a unique value.

Review effort: Lite (auto)

@felickz
felickz merged commit 66b0da2 into GitHubSecurityLab:main Nov 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants