Preserve linked page destinations in published search - #4566
Open
jpreynat wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 2890e1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Contributor
Style invalidation on a large API referenceElements restyled by opening one popup on the Snyk API reference. A share near or above 100% means the insertion restyles the whole document.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
href, including query strings and fragments in regular and embeddable searchhrefThe backend change in GitbookIO/gitbook-x#25237 makes linked sidebar pages searchable. This GBO change preserves their configured external destination when rendering the returned result.
Testing
bun run formatbun run lintcd packages/gitbook && bun run typecheckcd packages/gitbook && bun test src/app/sites/dynamic/[mode]/[siteURL]/[siteData]/~gitbook/search/route.test.ts(8 passed)Follow-up
Linear: RND-10265
Do not resolve the Linear issue on merge. After both backend and GBO changes are deployed, the affected Runway space still needs to be reindexed and verified in published search.