Skip to content

Commit 57cc0d7

Browse files
committed
review: remove GITHUB_APP_NAME reference from workflow
1 parent ec335a6 commit 57cc0d7

5 files changed

Lines changed: 1 addition & 10 deletions

File tree

.github/workflows/production.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ jobs:
7676
# GitHub
7777
GITHUB_APP_INSTALL_URL: ${{ secrets.GITBOOK_GITHUB_APP_INSTALL_URL }}
7878
GITHUB_APP_ID: ${{ secrets.GITBOOK_GITHUB_APP_ID }}
79-
GITHUB_APP_NAME: ${{ secrets.GITHUB_APP_NAME }}
8079
GITHUB_CLIENT_ID: ${{ secrets.GITBOOK_GITHUB_CLIENT_ID }}
8180
GITHUB_CLIENT_SECRET: ${{ secrets.GITBOOK_GITHUB_CLIENT_SECRET }}
8281
GITHUB_WEBHOOK_SECRET: ${{ secrets.GITBOOK_GITHUB_WEBHOOK_SECRET }}

.github/workflows/release.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ jobs:
9898
# GitHub
9999
GITHUB_APP_INSTALL_URL: ${{ secrets.GITBOOK_GITHUB_STAGING_APP_INSTALL_URL }}
100100
GITHUB_APP_ID: ${{ secrets.GITBOOK_GITHUB_STAGING_APP_ID }}
101-
GITHUB_APP_NAME: ${{ secrets.GITHUB_APP_NAME }}
102101
GITHUB_CLIENT_ID: ${{ secrets.GITBOOK_GITHUB_STAGING_CLIENT_ID }}
103102
GITHUB_CLIENT_SECRET: ${{ secrets.GITBOOK_GITHUB_STAGING_CLIENT_SECRET }}
104103
GITHUB_WEBHOOK_SECRET: ${{ secrets.GITBOOK_GITHUB_STAGING_WEBHOOK_SECRET }}

.github/workflows/test.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ jobs:
114114
# GitHub
115115
GITHUB_APP_INSTALL_URL: ${{ secrets.GITBOOK_GITHUB_STAGING_APP_INSTALL_URL }}
116116
GITHUB_APP_ID: ${{ secrets.GITBOOK_GITHUB_STAGING_APP_ID }}
117-
GITHUB_APP_NAME: ${{ secrets.GITHUB_APP_NAME }}
118117
GITHUB_CLIENT_ID: ${{ secrets.GITBOOK_GITHUB_STAGING_CLIENT_ID }}
119118
GITHUB_CLIENT_SECRET: ${{ secrets.GITBOOK_GITHUB_STAGING_CLIENT_SECRET }}
120119
GITHUB_WEBHOOK_SECRET: ${{ secrets.GITBOOK_GITHUB_STAGING_WEBHOOK_SECRET }}

integrations/github-issues/gitbook-manifest.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,6 @@ organization: gitbook
1414
configurations:
1515
account:
1616
componentId: config
17-
secrets:
18-
GITHUB_APP_ID: ${{ env.GITHUB_APP_ID }}
19-
GITHUB_APP_NAME: ${{ env.GITHUB_APP_NAME }}
20-
GITHUB_PRIVATE_KEY: ${{ env.GITHUB_PRIVATE_KEY }}
21-
CLIENT_ID: ${{ env.GITHUB_CLIENT_ID }}
22-
CLIENT_SECRET: ${{ env.GITHUB_CLIENT_SECRET }}
23-
WEBHOOK_SECRET: ${{ env.GITHUB_WEBHOOK_SECRET }}
2417
target: organization
2518
envs:
2619
dev-steeve:

integrations/github-issues/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"scripts": {
1818
"typecheck": "tsc --noEmit",
1919
"check": "gitbook check",
20+
"publish-integrations": "gitbook publish .",
2021
"publish-integrations-staging": "gitbook publish . --env staging"
2122
}
2223
}

0 commit comments

Comments
 (0)