Repository navigation
Add Fedora CI checks, tests, and sourceable guard for uki-setup.sh - #3
Closed
GlitchSlayed wants to merge 3 commits into
Closed
GlitchSlayed wants to merge 3 commits into
GlitchSlayed wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sourcefrom tests/CI so non-destructive validation can run without performing system changes.Description
.github/workflows/checks.ymlthat runs insidefedora:41, installs check dependencies, and runs Bash syntax checks,shellcheck, and project-level tests.uki-setup.shbehindUKI_SETUP_SKIP_MAIN, so tests cansourcethe file without triggering destructive phases.tests/test_uki_setup.shwhich sourcesuki-setup.shwithUKI_SETUP_SKIP_MAIN=1, runs the template-generation phases into a temporary workspace, and asserts the helper/plugin files are created, executable, and have placeholders substituted.README.mdwith a short section documenting the CI checks and the equivalent local commands to run the same validations.Testing
bash -n uki-setup.sh tests/test_uki_setup.shwas executed and returned successfully.bash tests/test_uki_setup.shwas executed locally and completed successfully, asserting generated files and substitutions.shellcheck uki-setup.sh tests/test_uki_setup.shcould not be run in this runtime becauseshellcheckwas not installed here, but the workflow installs and enforcesshellcheckin CI.Codex Task