Repository navigation
Add GPT autodiscovery advisory to status output - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rustyuki statusaware of Discoverable Partitions Specification (DPS) so users get a helpful advisory when their root partition already carries a discoverable GPT type GUID.root=cmdline tokens into UKIs by providing advisory (not automatic) guidance to remove them when GPT autodiscovery will work.Description
discoverable_root_advisoryinsrc/app.rswhich reads the configured cmdline file, checks for aroot=token, reads/proc/mountsto find the device mounted at/, and querieslsblk -no PARTTYPEfor that device to obtain the partition GPT type GUID.dps_root_guidmapping for architecture-specific DPS root GUIDs andparse_root_mount_sourcehelper to extract/mount source.discoverable_root_messageto format the two advisory outputs: an[INFO]advisory whenroot=is present and the partition GUID matches DPS, and an[OK]confirmation whenroot=is absent and the GUID matches; the code emits no automatic changes to the cmdline file.statusintegration test to use a temporary cmdline file; changes are all insrc/app.rsand test updates intests/integration_cli.rs.Testing
cargo fmt --allwhich completed successfully.cargo testwhich completed successfully; all unit and integration tests passed.Codex Task