Repository navigation
Auto-mount ESP during preflight and UKI build flows - #7
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/usr/local/sbin/uki-build.shcan also recover when run later (e.g., fromkernel-installhooks) if the ESP is not mounted.Description
find_esp_device(detect ESP partition vialsblkGUID/FSTYPE) andensure_esp_mountedhelpers touki-setup.shto try mounting/boot/efior/efiusing fstab first and falling back to mounting the detected ESP device with-t vfat.ensure_esp_mounted || die ...so the script attempts automatic mounting before aborting.find_esp_device/ensure_esp_mountedlogic into the generateduki-build.shtemplate and enforced it before building a UKI so rebuilds also auto-mount the ESP when possible.README.mdRequirements and Troubleshooting to document the auto-mount behavior and the fallback for manual mounting.Testing
bash -n uki-setup.sh tests/test_uki_setup.shwhich completed successfully.bash tests/test_uki_setup.shwhich passed and confirmed generated templates are populated as expected.shellcheck uki-setup.shbutshellcheckwas not available in the environment (not a failure of the change).Codex Task