Repository navigation
update bambu version and github workflows - #38
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the pipeline to a newer bambu API/container and refreshes GitHub Actions workflows to support building/publishing the R container and controlling CI concurrency.
Changes:
- Update
bambu.singlecell(...)calls to the neweroutput=...-driven API and adjust inputs/outputs accordingly (including removingsample_namesplumbing). - Simplify Seurat clustering outputs to a single
clusters.rdsmapping and remove unused R dependencies (IRanges). - Pin the R container to
ghcr.io/goekelab/bambu-pipe-r:1.0.0, switch the Docker build to a newer bambu branch, add a container build workflow, and update smoke-test workflow triggers/concurrency.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
subworkflows/clustering.nf |
Removes sample_names input and updates multi-sample Seurat invocation accordingly. |
modules/seurat/single_sample.nf |
Removes IRanges, changes how clusters are stored/exported from Seurat. |
modules/seurat/multi_sample.nf |
Removes IRanges and sample_names input; changes cluster labeling/export format. |
modules/bambu/transcript_discovery.nf |
Updates bambu calls to new API, removes sample_names emission, adjusts read/quant outputs. |
modules/bambu/EM_quant.nf |
Updates clustered EM invocation to pass reads=quantData and use new output modes. |
modules/bambu/construct_read_class.nf |
Updates read-class construction to new bambu API (output="readClasses"). |
main.nf |
Updates CLUSTERING wiring to match removed sample_names output. |
containers/r/Dockerfile |
Switches bambu git branch used during container build. |
conf/containers.config |
Pins the R container image/tag to ghcr.io/goekelab/bambu-pipe-r:1.0.0. |
.github/workflows/smoke_test.yml |
Adds concurrency + workflow_dispatch; removes push trigger (see comment). |
.github/workflows/build_container.yml |
Adds workflow to build/publish the R container tag derived from conf/containers.config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.