[codex] Fix session_end journal file filtering - #15
Open
duongngocbinh56599-ui wants to merge 2 commits into
Open
[codex] Fix session_end journal file filtering#15duongngocbinh56599-ui wants to merge 2 commits into
duongngocbinh56599-ui wants to merge 2 commits into
Conversation
Reuse isJournalFile in session_end journal scans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isJournalFile()insession_endjournal scans.index.mdfrom affecting update headings, merge suggestions, and save-card counts.Fixes #6.
Tests
npm run build -w packages/corenode --test packages/core/test/session-end-journal-filter.test.mjsnpm test -w packages/core(currently blocked by upstream version mismatch: packages/core/package.json is 3.4.19 while packages/core/src/types.ts VERSION is 3.4.18)我也是看到兄弟在X上发的帖子而来的，求兄弟帮下忙，给过一下。