feat: allow component to have a lock ratio - #6814
Open
UnderKoen wants to merge 1 commit into
Open
Conversation
Member
|
Make sense, but I wonder if it would make sense to add a new option as a function instead (eg. resizable: {
keepRatio: ({ handle, shiftKey }) => {
if (['cl', 'cr', 'tc', 'bc'].includes(handle)) return true;
return !shiftKey;
},
}wdyt? |
Contributor
Author
|
Maybe a mix? type keepRatio = 'ALWAYS' | 'NEVER' | 'DEFAULT' | (...) => boolean; |
Member
|
That makes more sense to me. My only doubt is DEFAULT: would it actually mean anything different from leaving the option unset/undefined? |
Contributor
Author
|
Didnt really know how to name it, as it would also be weird to have no explicit option for the default behavior. Maybe LOOSE |
Member
|
I'd prefer to have keepRatio simply undefined to indicate "default" behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to resize options that allows the component to keep it's ratio.
This disables the shift behaviour and adds the ratio keeping to the center resize handles.
I was thinking maybe this should have multiple modes that would allow shift resize
Or be split in 2 seprate options like
allowShiftRatioUnlock,enforceCenterRatio