improve desktop mode and swipe UX + use the recommended pdf.js canvas rendering API - #713
Open
inthewaves wants to merge 8 commits into
Open
improve desktop mode and swipe UX + use the recommended pdf.js canvas rendering API #713inthewaves wants to merge 8 commits into
inthewaves wants to merge 8 commits into
Conversation
Pass the canvas and device scale transform to pdf.js instead of creating and pre-scaling the rendering context. This uses the recommended canvas parameter[^1] and matches the upstream viewer canvas-plus-transform setup.[^2] The legacy canvasContext path produced black rectangles when rendering PDFs in WebView desktop mode. [^1]: https://github.com/mozilla/pdf.js/blob/v6.2.108/src/display/api.js#L1205-L1214 [^2]: https://github.com/mozilla/pdf.js/blob/v6.2.108/web/pdf_page_view.js#L1175-L1180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canvasContextis currently only being provided in pdf.js API for backwards compatibilityFootnotes
https://github.com/mozilla/pdf.js/blob/v6.2.108/src/display/api.js#L1205-L1214 ↩
https://github.com/mozilla/pdf.js/blob/v6.2.108/web/pdf_page_view.js#L1175-L1180 ↩