Repository navigation
Map Minecraft 26.1+ dimension paths to legacy DIM types - #109
Conversation
|
Fixes #106 |
|
Also seems to fix #107 |
|
@Gregory-AM @greatmastermario any chance we can get this merged? I have other incoming fixes that rely on this... |
stwalkerster
left a comment
There was a problem hiding this comment.
This looks mostly good to me (though I've not tested it), with one request to swap how we handle backwards compatibility.
Minecraft 26.1 moved region files from <world>/region/ to <world>/dimensions/minecraft/overworld/region/ (and similarly for nether and end). This adds a mapping so RegionSet correctly identifies the new paths as DIM0, DIM-1, and DIM1. Fix cross-platform test mocking for resolve_world_path tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…hecked. Update from 26.1.
0176b05 to
3bd7091
Compare
|
Seems that Windows is not affected, but there is some issue with upgrading |
…h Windows. - numpy: remove setup's use of errors for declaration-after-statement - Not required for 1.x, and must be left out for 2.x - also, relax hard requirement on numpy 1.24 to support Ubuntu 26 - Pillow v9-12 must be supported between Ubuntu versions (26.04 needs 12 support) - Imaging* functions renamed to ov_* - Pillow 12 declares these in its header - added support in composite.c/overviewer.c across Pillow versions (OV_MODE_IS macro, IMAGENING_MODE_* enum) Coauthored by Claude
|
Ah yeah, setup.py enforces Tested across all three Ubuntu versions, with their shipped versions of Python, and on Windows 11 with Python 3.14. |
greatmastermario
left a comment
There was a problem hiding this comment.
Changes look good to me. Need a maintainer review though before merging, and I am not a maintainer
|
Even on your branch I am getting the following failure: I am using the system default on Ubuntu 26.04 with the dependencies described in the docs installed: Are the installation instructions different? |
|
Ubuntu 26 wasn't out when I made this PR. Let me fix it up and move it to 22+24+26. (22 is EOL next year so we'll leave it in place for now). |
Update Python dependency pins and venv-based build paths for Ubuntu 26 support. Match Pillow source headers to the installed Pillow version and raise the documented Python baseline to 3.10. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Clone matching Pillow sources into the runner temp directory so pytest does not collect Pillow's own test configuration from the repository workspace. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Local build instructions are updated, now with (in my opinion of course) better assistance to ensure Pillow matches Python packages. @greatmastermario - Please have a go and let me know your thoughts! |
|
Latest revision:
|
Minecraft 26.1 moved region files from /region/ to /dimensions/minecraft/overworld/region/ (and similarly for nether and end). This adds a mapping so RegionSet correctly identifies the new paths as DIM0, DIM-1, and DIM1.
Fix cross-platform test mocking for resolve_world_path tests