Repository navigation
Drop pathlib2, scandir and typing from the dependency pins - #2358
Open
jorgeecardona wants to merge 1 commit into
Open
jorgeecardona wants to merge 1 commit into
jorgeecardona wants to merge 1 commit into
Conversation
These are backports for Python < 3.5 (scandir, typing) and < 3.8 (pathlib2). Guake supports 3.8+ (setup.cfg classifiers, CI matrix) and nothing under guake/ imports any of them; the only typing import is the stdlib module. No other package in Pipfile.lock depends on them. They were marker-guarded in [dev-packages], but df19099 replaced [packages] with an unconditional freeze that lost the markers. As a result scandir, which has no Linux wheels, is compiled from sdist on every CI job for every Python version. Pipfile.lock is edited by hand: only the three entries are removed and _meta.hash is the one pipenv 2024.4.0 (the version pinned in scripts/bootstrap-dev-pip.sh) computes for the new Pipfile; verified with `pipenv verify`. The generated requirements*.txt are trimmed by hand rather than regenerated to keep unrelated version bumps out of this change.
There was a problem hiding this comment.
🟢 Approval recommended
The lock file is valid, references are consistent, and CI passes across all supported Python versions.
0 open findings
What changed in this PR
Removes obsolete Python backport pins to avoid unnecessary dependency installation and scandir compilation.
Changes:
- Removes
pathlib2,scandir, andtypingpins. - Updates the lock hash and generated requirements files.
- Preserves remaining dependency versions.
| File | Description |
|---|---|
Pipfile |
Removes obsolete backport declarations. |
Pipfile.lock |
Removes corresponding locked packages and updates metadata. |
requirements.txt |
Removes the typing backport. |
requirements-dev.txt |
Removes all three backport pins. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pathlib2,scandirandtypingare backports for Python <3.8 / <3.5; nothing inguake/imports them and nothing in the lock depends on them.[packages]since df19099 (a freeze dump that lost the markers), soscandir, which has no Linux wheels, is compiled from sdist on every CI job.pipenv verifypasses.requirements*.txttrimmed, not regenerated, to keep unrelated version bumps out.CI on my fork: https://github.com/jorgeecardona/guake/actions/runs/38173687060