fix: prevent infinite loading loop in Frostbite Caves (fixes #17) - #19
Open
Lordfckx wants to merge 2 commits into
Open
fix: prevent infinite loading loop in Frostbite Caves (fixes #17)#19Lordfckx wants to merge 2 commits into
Lordfckx wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Sorry @Lordfckx, your pull request is larger than the review limit of 150000 diff characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
returnkeyword in theswitchWMgenerator that causedflowerOff()to be skipped, leaving the loading animation stuck foreverRoot Cause
In
worldMapScene.ts(switchWMmethod), the load callback generator had:The raw
returnexited the generator immediately, bypassingcase 19whereflowerOff()is called. This left the loader flower visible indefinitely — appearing as an "infinite loading loop."Fix
Removed
returnso execution falls through to subsequent cases:Now
p.init()→case 16→case 19→flowerOff()is always reached.Testing
System.register/_RF.popcounts preserved)switchWMcode path, so it benefits all worlds, not just Frostbite CavesNote
This is a patch to the compiled
docs/assets/main/index.js. The original TypeScript source was not available, so the equivalent TS fix would be removing thereturnbeforethis.currentWM = p; p.MapProps = h; ... p.init();inworldMapScene.ts:switchWM.