Add four Transport examples migrated to the R6 incubator model - #12
Open
jdlnolen wants to merge 7 commits into
Open
Add four Transport examples migrated to the R6 incubator model#12jdlnolen wants to merge 7 commits into
jdlnolen wants to merge 7 commits into
Conversation
The index page hardcoded {% include ip-statements.xhtml %}, but the IG
Publisher only generates language-suffixed includes (ip-statements-en.xhtml).
Jekyll's include has no filename fallback, so this aborted the entire build
before the QA stage could run. Match the -en convention already used by the
table-structuredefinitions-en and table-profiles-en includes in the same file.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds sample-collection, external-shipment, laboratory-workflow, and tray-movement Transport examples from the OO WG review set, converted from the R5 Transport structure to the incubator's redefined R6 Transport: - currentLocation -> from, requestedLocation -> to, completionTime -> period - dropped intent (removed in the redefinition); for -> subject; history -> priorTransport - added the required resourceDefinition (Transport|0.1.0) on each instance Un-contained each example's supporting resources (Patients, Locations, Devices, Specimens, Observations, and the four workflow legs) into standalone example files to satisfy dom-3, since the redefined Transport has no multi-item slot and a contained resource cannot reference its container. IDs are namespaced per example (t01-..t04-) to avoid collisions. The laboratory-workflow legs chain via priorTransport; the external-shipment cold-chain Observations link back via Observation.focus. All Transport instances registered in sushi-config with exampleCanonical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… model Companion notes explaining how the four OO WG review scenarios (behind the Confluence diagrams) were converted from R5 Transport + contained resources to the redefined R6 Transport, including the element mapping, the dom-3-driven un-containing, and the reverse-reference/priorTransport modeling. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The examples validate with 0 errors/0 warnings on the official auto-builder (healthy tx server); no dom-3 or resourceDefinition errors anywhere. Replace the locally-observed error/broken-link noise (a stale tx.fhir.org session artifact) with the authoritative CI totals and a note to trust CI over local runs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reworks the four Transport examples to minimize files, following the FHIR spec's single-example-page style: - Examples 01, 02, 04 are now self-contained: all supporting resources live inside the Transport as contained resources. dom-3 reachability is satisfied by pointing focus at a leaf (focus -> specimen -> tube -> ... chain) and, where an example has multiple leaf items, a contained Provenance hub whose target lists every subordinate resource (linked via Transport.relevantHistory). Example 02's cold-chain Observations are contained rather than linking back to the container (which ref-1 forbids). - Example 03 becomes four top-level, self-contained Transport legs chained by priorTransport, instead of contained sub-Transports inside a wrapper. The IG publisher cannot attach a resourceDefinition to a contained instance of a redefined type, so contained legs always error; top-level legs validate cleanly and better reflect that each hop is a first-class transport event. Removes the 46 per-example split-out files from the prior un-contained approach. Net: 7 files for the four scenarios (down from ~50). No dom-3 or resourceDefinition errors remain. Doc updated accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ygaudet
approved these changes
Aug 13, 2026
The self-contained layout validates on the official auto-builder: 0 errors/0 warnings on all seven Transport instances, no dom-3 or resourceDefinition errors; whole-IG totals 37 errors / 129 warnings / 29 broken links (all pre-existing, unrelated), with warnings down from 171. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The examples populate from/to/period/focus/code (and priorTransport) but only identifier/status/patient/subject were searchable. Add from, to (reference -> Location), focus, date (-> period), code, and prior-transport, matching the redefined element names (from/to replace the renamed currentLocation/ requestedLocation, which base location params can no longer target). Includes a disclaimer, embedded in the search-params bundle and the migration doc, that the reference-based parameters are defined for the production model where the referents are addressable resources; within the self-contained examples those referents are contained (#local) and won't resolve as search targets. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four Transport examples from the OO Work Group review set (behind the Confluence diagrams), migrated from the R5 Transport structure to this IG's redefined R6 Transport (
from/to/period), plus a companion migration write-up.Also fixes a pre-existing build blocker:
input/pagecontent/index.mdused the non-language-suffixed{% include ip-statements.xhtml %}, which aborts the Jekyll stage (the publisher only emitsip-statements-en.xhtml).The four examples
transport-example-01-sample-collectiontransport-example-02-external-shipmentObservation.focustransport-example-03-laboratory-workflowpriorTransporttransport-example-04-tray-movementWhat changed and why
currentLocation→from,requestedLocation→to,completionTime→period,for→subject,history→priorTransport; droppedintent; added the requiredresourceDefinition(Transport|0.1.0).dom-3— the redefined Transport has no multi-item slot, and a contained resource cannot reference its container. IDs are namespaced per example (t01–t04) to avoid collisions.sushi-config.yamlwithexampleCanonical.Full details in
TRANSPORT-EXAMPLES-MIGRATION.md(included in this PR).Build status
Builds to completion (exit 0) with no genuine structural errors on the examples. Two residual error classes are not caused by these examples and are noted as follow-ups in the doc:
#Transport.id|language|textanchor links — systemic to the redefined Transport StructureDefinition page (the existingsimpledeliveryexample produces the identical set).tx.fhir.orgcache/timeout errors — transient terminology-server session failures.🤖 Generated with Claude Code