Skip to content

Commit eb40e33

Browse files
authored
Merge pull request #80 from HL7/ACOM-GHS-support
Fix publication issue around absence of logical ids in examples
2 parents b9d6e8a + e1c46c2 commit eb40e33

15 files changed

Lines changed: 47 additions & 33 deletions

input-cache/jiraspec.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<specification xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" ballotUrl="http://hl7.org/fhir/uv/phd/2025Sep" ciUrl="http://build.fhir.org/ig/HL7/phd" defaultVersion="2.0.0-ballot2" defaultWorkgroup="dev" gitUrl="https://github.com/HL7/PHD" url="http://hl7.org/fhir/uv/phd">
2+
<specification xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" ballotUrl="http://hl7.org/fhir/uv/phd/2025Sep" ciUrl="http://build.fhir.org/ig/HL7/phd" defaultVersion="1.1.0" defaultWorkgroup="dev" gitUrl="https://github.com/HL7/PHD" url="http://hl7.org/fhir/uv/phd">
33
<version code="current" url="http://build.fhir.org/ig/HL7/phd"/>
44
<version code="2.0.0-ballot2" url="http://hl7.org/fhir/uv/phd/2025Sep"/>
5-
<version code="2.0.0-ballot" deprecated="true" url="http://hl7.org/fhir/uv/phd/2024Sep"/>
65
<version code="1.1.0" url="http://hl7.org/fhir/uv/phd/STU1.1"/>
6+
<version code="2.0.0-ballot" deprecated="true" url="http://hl7.org/fhir/uv/phd/2024Sep"/>
77
<version code="1.0.0" deprecated="true" url="http://hl7.org/fhir/uv/phd/STU1"/>
88
<version code="0.3.0" deprecated="true" url="http://hl7.org/fhir/uv/phd/2019May"/>
99
<version code="0.2.0" deprecated="true" url="http://hl7.org/fhir/uv/phd/2019Jan"/>

input/examples/glucose-observation.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"resourceType": "Observation",
3+
"id": "glucose-observation",
34
"meta": {
45
"profile": [
56
"http://hl7.org/fhir/uv/phd/StructureDefinition/PhdNumericObservation"

input/examples/meal-context-observation.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"resourceType": "Observation",
3+
"id": "meal-context-observation",
34
"meta": {
45
"profile": [
56
"http://hl7.org/fhir/uv/phd/StructureDefinition/PhdCodedEnumerationObservation"

input/examples/rtsa-example-2.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"resourceType": "Observation",
3+
"id": "rtsa-example-2",
34
"meta": {
45
"profile": [
56
"http://hl7.org/fhir/uv/phd/StructureDefinition/PhdRtsaObservation"

input/examples/rtsa-example.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"resourceType": "Observation",
3+
"id": "rtsa-example",
34
"meta": {
45
"profile": [
56
"http://hl7.org/fhir/uv/phd/StructureDefinition/PhdRtsaObservation"

input/examples/string-observation-1.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"resourceType": "Observation",
3+
"id":"string-observation-1",
34
"meta": {
45
"profile": [
56
"http://hl7.org/fhir/uv/phd/StructureDefinition/PhdStringObservation"

input/examples/temperature-observation.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"resourceType": "Observation",
3+
"id": "temperature-observation",
34
"meta": {
45
"profile": [
56
"http://hl7.org/fhir/uv/phd/StructureDefinition/PhdNumericObservation"

input/fsh/CodeSystem.ASN1ToHL7.fsh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ Description: "CodeSystem for mapping IEEE 11073-10206 bitstrings to FHIR Codeabl
2020
* ^publisher = "Health Level Seven International (Devices Work Group)"
2121
* ^caseSensitive = true
2222
* ^content = #complete
23-
* ^extension[+].url = "http://hl7.org/fhir/StructureDefinition/structuredefinition-standards-status"
24-
* ^extension[=].valueCode = #trial-use
25-
* ^extension[=].valueCode.extension.url = "http://hl7.org/fhir/StructureDefinition/structuredefinition-conformance-derivedFrom"
26-
* ^extension[=].valueCode.extension.valueCanonical = "http://terminology.hl7.org/CodeSystem/ASN1ToHL7"
23+
// * ^extension[+].url = "http://hl7.org/fhir/StructureDefinition/structuredefinition-standards-status"
24+
// * ^extension[=].valueCode = #trial-use
25+
// * ^extension[=].valueCode.extension.url = "http://hl7.org/fhir/StructureDefinition/structuredefinition-conformance-derivedFrom"
26+
// * ^extension[=].valueCode.extension.valueCanonical = "http://terminology.hl7.org/CodeSystem/ASN1ToHL7"
2727

2828

2929
* ^property[0].code = #eventOrState

input/fsh/StructureDefinition.CoincidentTimeStampReference.fsh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ Context: Observation
99
* ^extension[=].valueCode = #dev
1010
* ^extension[+].url = "http://hl7.org/fhir/StructureDefinition/structuredefinition-fmm"
1111
* ^extension[=].valueInteger = 1
12-
* ^extension[+].url = "http://hl7.org/fhir/StructureDefinition/structuredefinition-standards-status"
13-
* ^extension[=].valueCode = #trial-use
12+
// * ^extension[+].url = "http://hl7.org/fhir/StructureDefinition/structuredefinition-standards-status"
13+
// * ^extension[=].valueCode = #trial-use
1414
* ^extension[+].url = "http://hl7.org/fhir/StructureDefinition/structuredefinition-type-characteristics"
1515
* ^extension[=].valueCode = #can-bind
1616
* ^url = "http://hl7.org/fhir/uv/phd/StructureDefinition/CoincidentTimeStampReference"

input/ignoreWarnings.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@ The type of property 'code' is 'code', but no ValueSet information was found, so
3131
This element does not match any known slice defined in the profile http://hl7.org/fhir/uv/phd/StructureDefinition/PhdNumericObservation|2.0.0-ballot2 (this may not be a problem, but you should check that it's not intended to match a slice)
3232

3333
# This informational message is due to inheriting this extension from the core specification.
34-
The extension http://hl7.org/fhir/StructureDefinition/elementdefinition-maxValueSet|5.2.0 is deprecated
34+
The extension http://hl7.org/fhir/StructureDefinition/elementdefinition-maxValueSet|5.3.0-ballot-tc1 is deprecated with the note Use additionalBinding extension or element instead
35+
36+
# We will switch to the new Device Gateway extension in the next version of the PHD IG.
37+
The extension http://hl7.org/fhir/StructureDefinition/observation-gatewayDevice|5.3.0-ballot-tc1 is deprecated with the note Use Device Gateway (device-gateway) extension which allows codeableReference (Device) in R6 and requires cross version extension for codeable reference.
3538

3639
# This warning is generated on purpose in two examples that use a private code on purpose. This warning can hence safely be ignored.
3740
Constraint failed: mdc-1: 'A published MDC Code is preferred but private MDC codes are allowed as well.' (defined in http://hl7.org/fhir/uv/phd/StructureDefinition/PhdBaseObservation)

0 commit comments

Comments
 (0)