[Bugfix] 修复 CurseForge 搜索部分内容正确结果很靠下的问题 & 移除没有实际意义的搜索排序方式 - #6619
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cba5441361
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@burningtnt 帮忙看看？ |
ToobLac
changed the title
# Conflicts: # HMCL/src/main/resources/assets/lang/I18N_uk.properties
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eaba39b344
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sortComboBox.prefWidthProperty().bind(sortStackPane.widthProperty()); | ||
| sortComboBox.getStyleClass().add("fit-width"); | ||
| sortComboBox.setConverter(stringConverter(sortType -> i18n("curse.sort." + sortType.name().toLowerCase(Locale.ROOT)))); | ||
| sortComboBox.setConverter(stringConverter(sortType -> i18n("addon.sort." + sortType.name().toLowerCase(Locale.ROOT)))); |
There was a problem hiding this comment.
When the launcher uses German, this converter now requests addon.sort.*, but I18N_de.properties still defines only the former curse.sort.* keys, so every sort label falls back to English. The Arabic, Spanish, Japanese, Literary Chinese, Russian, and Ukrainian bundles also omit addon.sort.relevancy, leaving the new default option in English; add the new key family to every supported locale so this control remains localized.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
2 participants
根据我的理解，ModsSearchSortField 里面第一项
Featured就是按相关性排序，要不然无法解释 CF 自己的搜索界面上Relevancy排序方式是哪来的。因此我用这个选项替代了原本 HMCL 自己实现的并不完善的相关性排序