All issues

[code-audit] postSetGdoMulti omits timeoutMs — silent 5000ms default inconsistent with all other callers that set it explicitly

#67

· Haglerd opened

on Jul 26, 2026

[code-audit] formatVal has redundant boolean branch — String(true) already returns 'true'

#66

· Haglerd opened

on Jul 26, 2026

[code-audit] buildDigestAuthHeaderFromCached emits algorithm from cache but always computes MD5 — SHA-256 challenge would produce wrong response

#65

· Haglerd opened

on Jul 26, 2026

[code-audit] normalizeHost silently accepts subpath in ratgdoHost URL — all requests silently fail with wrong base path

#64

· Haglerd opened

on Jul 26, 2026

[code-audit] closedAt stores Date.now() in useForceClose branch but is only used as a boolean flag

#63

· Haglerd opened

on Jul 26, 2026

[code-audit] try/catch blocks in verifyCloseStarted and waitForDoorClosed are unreachable — getStatusJson never throws

#62

· Haglerd opened

on Jul 26, 2026

[code-audit] httpUpLogged boolean in waitForRatgdoReady is redundant — httpUpAt !== null captures the same state

#60

· Haglerd opened

on Jun 21, 2026

[code-audit] setServiceName JSDoc comment block misplaced — appears before mapDoorStateToHK instead of before setServiceName

#59

· Haglerd opened

on Jun 21, 2026

[code-audit] runReboot and runReconnectHK use hardcoded timeoutMs:5000 — unnamed magic number

#61

· Haglerd opened

on Jun 21, 2026

[code-audit] startStatusPolling log says "for sensors" — misleading when polling runs for GarageDoorOpener tile with no sensors configured

#56

· Haglerd opened

on Jun 21, 2026

[code-audit] probeIntervalMs=500 independently declared in three functions — same literal as POLL_INTERVAL_MS in runForceClose useForceClose branch

#57

· Haglerd opened

on Jun 21, 2026

[code-audit] statusPollIntervalMs schema description says "only runs when sensors enabled" — inaccurate, polling also drives GarageDoorOpener tile

#58

· Haglerd opened

on Jun 21, 2026