Improve support for native DOSBox and ScummVM on macOS - #85
Merged
Conversation
We also look for dosbox-staging in the PATH as e.g. Homebrew installs it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch extends the use of native executables for DOSBox and ScummVM games to also search for and use macOS application bundles, based on their application IDs (
io.github.dosbox-stagingandorg.scummvm.app, respectively). It also addsdosbox-stagingto the list of programs searched for in thePATHvariable; this is the name Homebrew, the package manager commonly used on macOS, uses for DOSBox Staging.I have not been able to test this change extensively, because of the problem fixed by #82, because DOS and ScummVM games did not install correctly on my macOS machine, and ultimately because I was not able to prepare a custom
heroic-gogdlexecutable locally. However, I have validated that theget_app_bundle_commandfunction does what it's supposed to do via the Python REPL.Advice on how to go about testing this more reliably would be appreciated.