[ELUSoC'26] Add coverage for expired tokens and invalid expiry values - #200
Closed
Shikha18Shukla wants to merge 3 commits into
Closed
[ELUSoC'26] Add coverage for expired tokens and invalid expiry values#200Shikha18Shukla wants to merge 3 commits into
Shikha18Shukla wants to merge 3 commits into
Conversation
|
@Shikha18Shukla is attempting to deploy a commit to the himanshipathak-240263-3015's projects Team on Vercel. A member of the Team first needs to authorize it. |
Him-an-shi
reviewed
Jul 26, 2026
Him-an-shi
left a comment
Owner
There was a problem hiding this comment.
Hi! @Shikha18Shukla Please resolve merge issues
Contributor
Author
|
Hi @Him-an-shi , I checked the PR and GitHub shows there are no merge conflicts with the base branch. The failing PR Quality Check appears to stop at the |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Closes #166
📝 Summary
Added missing test coverage for share link lifecycle validation in
backend/tests/test_sharing.py.This PR improves the robustness of the sharing feature by adding tests for expired share tokens and invalid expiry inputs. The added test cases ensure that invalid requests are properly rejected and expired links cannot be accessed.
🔧 Changes Made
Added the following test cases:
test_view_shared_data_expiredtest_create_share_link_negative_expiryexpiresInDaysvalues.400 Bad Request.test_create_share_link_invalid_type_expiry400 Bad Request.These tests extend the existing sharing test suite by covering important edge cases around token expiration and input validation.
📸 Screenshots (if UI changed)
Not applicable.
This PR only modifies backend tests and does not include any UI changes.
🧪 Testing Performed
Share Link Test Suite
Command: