Skip to content

Refactor cycle update and delete tests - #249

Closed
mspandey wants to merge 1 commit into
Him-an-shi:mainfrom
mspandey:patch-24
Closed

Refactor cycle update and delete tests#249
mspandey wants to merge 1 commit into
Him-an-shi:mainfrom
mspandey:patch-24

Conversation

@mspandey

@mspandey mspandey commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description

This pull request resolves Issue #170 by consolidating the fragmented and duplicated TestUpdateCycle and TestDeleteCycle classes in backend/tests/test_cycles.py.

Details:

  • Class Consolidation: Merged all test methods for updating and deleting cycles into single, unified TestUpdateCycle and TestDeleteCycle classes respectively.
  • Removal of Duplicates: Eliminated duplicate not_found test definitions that resulted from the fragmented class structure.
  • Pipeline Integrity: Ensures success tests (test_update_cycle_success and test_delete_cycle_success) are no longer shadowed and are fully executed during test runs.

Closes #170

### Description
This pull request resolves [Issue #170](#170) by consolidating the fragmented and duplicated `TestUpdateCycle` and `TestDeleteCycle` classes in `backend/tests/test_cycles.py`.

#### Details:
* **Class Consolidation:** Merged all test methods for updating and deleting cycles into single, unified `TestUpdateCycle` and `TestDeleteCycle` classes respectively.
* **Removal of Duplicates:** Eliminated duplicate `not_found` test definitions that resulted from the fragmented class structure.
* **Pipeline Integrity:** Ensures success tests (`test_update_cycle_success` and `test_delete_cycle_success`) are no longer shadowed and are fully executed during test runs.

Closes #170
Copilot AI lite review requested due to automatic review settings August 4, 2026 18:51
@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

@mspandey is attempting to deploy a commit to the himanshipathak-240263-3015's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

@Him-an-shi Heads up: @mspandey has opened 6 items in the last 24 hours. Flagging for review to check for potential bulk/automated submissions.

@mspandey mspandey closed this by deleting the head repository Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(cycles): fix shadowed test classes silently skipping success tests

2 participants