chore(gitignore): match the run_notes directory csv mode writes - #208
Closed
lfnothias wants to merge 1 commit into
Closed
chore(gitignore): match the run_notes directory csv mode writes#208lfnothias wants to merge 1 commit into
lfnothias wants to merge 1 commit into
Conversation
.gitignore listed runs_notes/* twice, but csv_mode.py writes benchmark manifests under run_notes/, so a run left an untracked file in the tree. Use the real name once. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
|
Closing. First, a question this raises rather than answers: where does benchmark_manifest.json come from in the first place? This change should have been linked to whatever PR introduced that file. As far as I can tell it comes from #198's evaluation changes, which are themselves an anti-pattern (a separated evaluation system (different repo) should consume capsules produced by the normal pipeline, not add new artifacts to it). Separately: no files under run_notes should ever be committed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.gitignorelistsruns_notes/*twice, butcsv_mode.pywrites benchmark manifests underrun_notes/, so every benchmark run leavesrun_notes/benchmark_manifest.jsonuntracked in the working tree.Solution
Replace both entries with one
run_notes/*.Testing
With a
run_notes/benchmark_manifest.jsonpresent,git status --shortis empty on this branch.Backwards compatibility
Not affected.
🤖 Generated with Claude Code