Skip to content

neovide: install desktop file and icons under Linux - #301415

Open
zeitue wants to merge 1 commit into
Homebrew:mainfrom
zeitue:neovide-desktop-file
Open

neovide: install desktop file and icons under Linux#301415
zeitue wants to merge 1 commit into
Homebrew:mainfrom
zeitue:neovide-desktop-file

Conversation

@zeitue

@zeitue zeitue commented Aug 30, 2026

Copy link
Copy Markdown

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

The brew Neovide formula does not install the desktop file or icons on LInux. This is needed for immutable distros like Blufin, Bazzite, Aurora, and defenestraOS to show the launcher for Neovide.

So this PR just adds these files to the brew installation from the pulled archive.

I've read through the Contribution process, I did not check the first box because I am not sure if I got everything.

AI was used to verify code and PR process (Gemini, Claude).

@github-actions github-actions Bot added rust Rust use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Aug 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for contributing to Homebrew! 馃帀 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Comment thread Formula/n/neovide.rb
Comment on lines +67 to +73
if OS.linux?
(share/"applications").install "assets/neovide.desktop"
(share/"icons/hicolor/scalable/apps").install "assets/neovide.svg"
%w[16x16 32x32 48x48 256x256].each do |size|
(share/"icons/hicolor/#{size}/apps").install "assets/neovide-#{size}.png" => "neovide.png"
end
end

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't cargo install these in the right locations? This seems very fragile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icu4c ICU use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants