neovide: install desktop file and icons under Linux - #301415
Open
zeitue wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for contributing to Homebrew! 馃帀 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
SMillerDev
reviewed
Aug 31, 2026
Comment on lines
+67
to
+73
| if OS.linux? | ||
| (share/"applications").install "assets/neovide.desktop" | ||
| (share/"icons/hicolor/scalable/apps").install "assets/neovide.svg" | ||
| %w[16x16 32x32 48x48 256x256].each do |size| | ||
| (share/"icons/hicolor/#{size}/apps").install "assets/neovide-#{size}.png" => "neovide.png" | ||
| end | ||
| end |
Member
There was a problem hiding this comment.
Can't cargo install these in the right locations? This seems very fragile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?The brew Neovide formula does not install the desktop file or icons on LInux. This is needed for immutable distros like Blufin, Bazzite, Aurora, and defenestraOS to show the launcher for Neovide.
So this PR just adds these files to the brew installation from the pulled archive.
I've read through the Contribution process, I did not check the first box because I am not sure if I got everything.
AI was used to verify code and PR process (Gemini, Claude).