llvm: fix duplicate archive member LTO conversion - #301599
Open
brendan-nasa wants to merge 1 commit into
Open
Conversation
Static archives can contain multiple members with the same name. Extracting them into one directory overwrites all but one, while `llvm-ar r` updates only the first matching member. This can leave bitcode behind and replace one translation unit with another. Extract members separately, rebuild archives after conversion, and add regression coverage for duplicate member names. Closes Homebrew#301252.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?I drafted this PR in conversation with a combination GPT 5.6 Sol, Sonnet 5, and Opus 5. By hand, I verified the root cause, the behavior of the ruby code, compared it to the new behavior, and verified the fix worked correctly. The project that depends on
libClangDriver.aalso now correctly links.Static archives can contain multiple members with the same name. Extracting them into one directory overwrites all but one, while
llvm-ar rupdates only the first matching member. This can leave bitcode behind and replace one translation unit with another.Extract members separately, rebuild archives after conversion, and add regression coverage for duplicate member names.
Closes #301252.