Skip to content
This repository was archived by the owner on May 19, 2026. It is now read-only.

Commit f47311b

Browse files
committed
Change the target in the cloudbuild.yaml to dev
There were failures because it relied on eslint being installed which is a dev dependency. The main reason we run checks against a production container is to ensure that the exact deployed environment works. Here, we only need build-and-test step as deployment is a manual process so the build isn't producing a production container (I THINK!) and so it should be ok to run tests and linting against a dev env.
1 parent 451b263 commit f47311b

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

cloudbuild.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ steps:
1313
- -c
1414
- |
1515
docker build \
16-
--target production \
16+
--target dev \
1717
-t europe-west1-docker.pkg.dev/${PROJECT_ID}/hubblehq-docker/request \
1818
.
1919
- id: 'Run linting'
@@ -24,10 +24,10 @@ steps:
2424
- |
2525
docker compose \
2626
-f docker-compose.yml \
27-
--profile production \
27+
--profile dev \
2828
run \
2929
--rm \
30-
production yarn lint
30+
dev yarn lint
3131
waitFor: ['Build image']
3232

3333
- id: 'Run tests'
@@ -38,10 +38,10 @@ steps:
3838
- |
3939
docker compose \
4040
-f docker-compose.yml \
41-
--profile production \
41+
--profile dev \
4242
run \
4343
--rm \
44-
production yarn test
44+
dev yarn test
4545
waitFor: ['Build image', 'Run linting']
4646

4747
substitutions:

0 commit comments

Comments
 (0)