Repository navigation
fix: correct promoted Docker image version - #9983
Closed
bioinformatist wants to merge 2 commits into
Closed
bioinformatist wants to merge 2 commits into
bioinformatist wants to merge 2 commits into
Conversation
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for label-studio-storybook canceled.
|
✅ Deploy Preview for label-studio-playground canceled.
|
Author
|
@smohan123 A tiny PR. |
Contributor
|
Our DevOps team will need to review this carefully before approving. I am unable to approve it for merge. |
Member
|
Sorry, that's not the right fix, it was my mistake when I pushed a security release in an old branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #9965.
The published
heartexlabs/label-studio:1.23.2image reportslabel_studio.__version__ == "1.23.0", causing the startup update notice evenafter upgrading. Reproduced on Linux amd64 with the fixed image digest
sha256:afcc516a22775a39d0d66f4c2ddc95d01be3e3d3862b21fcf4f9de34b4ad4e12:The runtime reads the installed distribution metadata. Promotion only copies
version_.py, leaving the candidate's project version and installed metadataunchanged. Updating that file alone cannot fix the reported version. Its
generation also currently precedes the step that sets the version overrides.
Change
Update only
.github/workflows/docker-release-promote.yml:vfrom the release tag and generateversion_.pyin the preparation step, with the overrides already set.
uv version --frozen, then use the image's existing system pip to reinstallonly Label Studio in editable mode into its application virtual environment.
--no-depspreserves runtime dependencies;pip --pythondoes not requirepip to be installed in that target environment.
label_studio.__version__against the normalized release version oneach built image before exporting its digest for manifest publication.
This keeps promotion based on the tested candidate. It does not rebuild the
frontend, manually patch installed metadata, bootstrap an installer, or add uv
to the final image. Platform selection, tag selection and the manifest merge
job are unchanged. Editable installation uses the project's declared build
backend rather than assuming one backend's metadata layout.
Validation
Tested against base commit
097b2b2198f8db3ccfe80838d887fc77a67625e3, usinguv 0.12.3 and the regression image's existing pip 26.2.1.
built its generated Dockerfile on
linux/amd64, substituting only thecandidate
FROMtag with the fixed regression digest above.1.23.2,v1.23.2and1.23.2.post0all passed the actual runtimeassertion, reporting
1.23.2,1.23.2and1.23.2.post0, respectively.170 other application distributions and one system distribution were
unchanged. Project/version metadata had the expected changes, exactly one
Label Studio distribution remained, and editable installation was preserved.
No uv binary or additional cache files remained.
uv_buildbackend. The latter installed successfully from read-only sourceinto a pip-free virtual environment, reporting
1.24.0.dev0with exactly oneproject distribution and without adding pip to that environment.
git diff --checkpassed. Compared the platform matrix,tag-selection logic and merge job with the baseline; all are unchanged.
These are local checks, not a completed release. Native arm64 execution and
the upstream release workflow still need validation. The added assertion must
pass on both platforms before their digests reach the dependent manifest job.
This PR does not change already-published images.