Skip to content

fix: wait for auth callback server readiness - #249

Merged
krowvin merged 1 commit into
mainfrom
fix/auth-callback-test-readiness
Aug 5, 2026
Merged

fix: wait for auth callback server readiness#249
krowvin merged 1 commit into
mainfrom
fix/auth-callback-test-readiness

Conversation

@krowvin

@krowvin krowvin commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • wait until the local OIDC callback server has bound its socket before the test connects
  • use an OS-assigned port so parallel or local processes cannot collide with a fixed test port
  • keep the production callback implementation unchanged

Failure addressed

This fixes the intermittent Python 3.9 failure observed in workflow run 31043633835, job 92433739624.

The test started the callback server on a background thread and immediately attempted to connect. On the failed runner, the client won that race and received ConnectionRefusedError: [Errno 111] Connection refused before the server had bound and begun listening. The same test passed in the Python 3.12 job and in other runs, confirming this was a timing-dependent test failure rather than a regression in PR #247.

Validation

  • targeted test passed 25 consecutive runs with zero failures
  • full local suite: 232 passed
  • pre-commit: all hooks passed
  • local GitHub Actions fork with act, Ubuntu and Python 3.9.25: smoke test passed and 232 tests passed

The local workflow fork replaced only the Poetry setup action with pip install poetry because act did not propagate that action's PATH update; the repository workflow itself is unchanged.

@krowvin
krowvin requested a review from Enovotny as a code owner August 5, 2026 20:33
@krowvin krowvin changed the title test: wait for auth callback server readiness fix: wait for auth callback server readiness Aug 5, 2026
@krowvin
krowvin merged commit ca39d5b into main Aug 5, 2026
9 checks passed
@krowvin
krowvin deleted the fix/auth-callback-test-readiness branch August 5, 2026 20:48
msweier pushed a commit that referenced this pull request Aug 10, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.8.0](v0.7.4...v0.8.0)
(2026-08-10)


### Features

* Add CDA Environment Manager
([#209](#209))
([a89bfb1](a89bfb1))
* add dev helper script to preview docs
([#253](#253))
([749fedc](749fedc))
* Add modern DSS transfer utilities
([#242](#242))
([89e01f4](89e01f4))
* allow for line return tsid parsing
([#230](#230))
([39f7f6b](39f7f6b))
* display CDA server stack traces in debug mode
([#247](#247))
([c3bfcf9](c3bfcf9))


### Bug Fixes

* align formatting checks
([#229](#229))
([a6286b3](a6286b3))
* cover explicit blob media type
([#232](#232))
([1a3b26d](1a3b26d))
* doc check, add link exception
([#255](#255))
([0101968](0101968))
* explain empty location loads
([#233](#233))
([a5b596c](a5b596c))
* harden clob download error handling
([#235](#235))
([621f913](621f913))
* Improve version issue error message in deps.py
([#245](#245))
([f77b75f](f77b75f))
* refresh ownership metadata
([#251](#251))
([3b31479](3b31479))
* show update environment before confirmation
([#246](#246))
([500435c](500435c)),
closes
[#222](#222)
* validate blob list limits
([#231](#231))
([0917ce9](0917ce9))
* validate load target cda
([#236](#236))
([ff3e06a](ff3e06a))
* wait for auth callback server readiness
([#249](#249))
([ca39d5b](ca39d5b))


### Documentation

* guide agents to shared color helpers
([#248](#248))
([ef03276](ef03276))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant