Delete unused variable copy operations - #64
Open
boyceg wants to merge 1 commit into
Open
Conversation
Replace the private dummy copy operations in nine Variable classes with deleted declarations. Keep IndexVariable's urgent fix separate. Add a compile-only check for explicit instantiation and noncopyability in 1D, 2D, and 3D.
drwells
reviewed
Aug 31, 2026
| CHECK_COPY_CONTROL_DIMENSIONS(SAMRAI::pdat::SideVariable) | ||
|
|
||
| #undef CHECK_COPY_CONTROL_DIMENSIONS | ||
| #undef CHECK_COPY_CONTROL |
Contributor
Author
There was a problem hiding this comment.
This is Codex applying IBAMR's rule of "changes in the code require corresponding tests". 😆
Member
There was a problem hiding this comment.
I appreciate the proactivity but since we don't test this project (aside from testing it against IBAMR) we can skip it in this context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue the cleanup begun in #63 by replacing unused copy operations in the other variable classes with
= deleteand adding regression tests.