Repository navigation
Conversation
vishu-bh
marked this pull request as ready for review
October 21, 2026 13:24
vishu-bh
requested review from
Lang-Akshay,
brian-hussey,
crivetimihai,
ja8zyjits and
msureshkumar88
as code owners
October 21, 2026 13:24
marekdano
previously approved these changes
Oct 21, 2026
brian-hussey
dismissed stale reviews from Lang-Akshay and marekdano
via
October 22, 2026 14:22
fccd8b1
brian-hussey
force-pushed
the
7297-admin-ui-deprecation-banner
branch
from
October 22, 2026 14:22
a33c1fa to
fccd8b1
Compare
Display a default-on notice with the support deadline and links to the new UI. Allow dismissal until refresh. Closes #7297 Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
vishu-bh
force-pushed
the
7297-admin-ui-deprecation-banner
branch
from
October 23, 2026 13:22
fccd8b1 to
68bb3a7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🔗 Related Issue
Closes #7297
📝 Summary
Show a red deprecation banner below the shared Admin UI header after login. The notice announces that support ends on 27 January 2027.
MCPGATEWAY_UI_DEPRECATION_NOTICE_ENABLED.The date is informational. This change adds no automatic expiry, redirect, or Admin UI shutdown.
Dark mode
📏 Reviewability
triage🏷️ Type of Change
🧪 Verification
make ruff bandit interrogate pylint TARGET='mcpgateway/config.py mcpgateway/admin.py'PRE_COMMIT_HOME="$PWD/.cache/pre-commit-home" .venv/bin/pre-commit run --show-diff-on-failurenode_modules/.bin/htmlhint mcpgateway/templates/admin.html.venv/bin/python -m pytest tests/unit/mcpgateway/test_admin.py tests/unit/mcpgateway/test_config.py --no-cov -p no:rerunfailures.venv/bin/python -m pytest tests/live_gateway/e2e/test_admin_deprecation_notice.py -o addopts= -p no:rerunfailures -p no:playwright --no-cov -q.venv/bin/ty check tests/live_gateway/e2e/test_admin_deprecation_notice.py.venv/bin/mypy --follow-imports=silent tests/live_gateway/e2e/test_admin_deprecation_notice.py.venv/bin/pyrefly check tests/live_gateway/e2e/test_admin_deprecation_notice.pymake verifymake lintmake testmake coverage diff-covermake docker-nuke docker-prod-rust testing-up RUST_MCP_MODE=make test-e2emake detect-secrets-scanLive validation uses temporary gateways and an isolated SQLite database. Set the flag identically in the gateway and test process.
Install Playwright Chromium for the browser regression test.
Browser checks cover mouse and keyboard dismissal, refresh restoration, tab navigation, scrolling, desktop and mobile layouts, and both themes.
✅ Checklist
make black isort pre-commit)Formatting verification uses the repository's Ruff pre-commit hooks. The secret baseline changes update existing finding line numbers.
📓 Notes (optional)
This PR remains a draft until the full pre-merge gate completes. Pending checks have no approved waiver.
The linked issue still carries
triage. The AI-assisted reviewability checkbox requires author confirmation.Manual reproduction:
true.MCPGATEWAY_UI_DEPRECATION_NOTICE_ENABLED=falseand restart. Confirm that the banner disappears.