Skip to content

Fix idr0106 to download from ftp instead of github - #225

Open
will-moore wants to merge 7 commits into
IDR:masterfrom
will-moore:download_urls_github_ftp
Open

Fix idr0106 to download from ftp instead of github#225
will-moore wants to merge 7 commits into
IDR:masterfrom
will-moore:download_urls_github_ftp

Conversation

@will-moore

@will-moore will-moore commented Jun 23, 2026

Copy link
Copy Markdown
Member

For all "github" studies, where the companion.ome file or .pattern file is on github and the rest of the files are available on ftp, we have made sure that the companion.ome file or .pattern file has the correct download url, but the tiff files do NOT get the correct URL.
This is probably the wrong way to go, as most users probably care more about downloading the tiff files that the pattern/companion file.

For some studies (idr0075, idr0079, idr0106) the client_paths in the Filesets are consistent with respect to download URLs on ftp. So we can get a download URL via simple replace.

To test, we can open the tsv from this PR and check those rows with:
https://proxy-idr-ap1.dundee.ac.uk/download_urls/?tsv=https://raw.githubusercontent.com/will-moore/idr.openmicroscopy.org/refs/heads/download_urls_github_ftp/_data/download_urls.tsv

We can also use the tsv for individual images. E.g. https://proxy-idr-ap1.dundee.ac.uk/webclient/img_detail/12689244/?check_links=true&tsv=https://raw.githubusercontent.com/will-moore/idr.openmicroscopy.org/refs/heads/download_urls_github_ftp/_data/download_urls.tsv - all the tif links are now "green", but companion.ome is not.

Other studies are more complex:
Known issues (GitHub studies not fixed by this PR):

@will-moore
will-moore force-pushed the download_urls_github_ftp branch from 6691525 to 41b460f Compare June 23, 2026 15:10
@pwalczysko

Copy link
Copy Markdown
Contributor

What is needed here please ? Testing ? How ?

@will-moore

Copy link
Copy Markdown
Member Author

Testing, yes please, using ?tsv=https://raw.githubusercontent.com/will-moore/idr.openmicroscopy.org/refs/heads/download_urls_github_ftp/_data/download_urls.tsv as in the first 2 links in the description to modify the download_urls page and individual pages to use the tsv from this PR.

On the download_urls page, check rows for idr0075, idr0079, idr0106.
Then try opening various images from those studies in iviewer, also appending the ?tsv=... to the URL once you've opened the viewer / download page.
E.g. idr106 image at https://proxy-idr-ap1.dundee.ac.uk/webclient/img_detail/12689244/?check_links=true
This is with the &check_links=true to get auto checking of the links.
That page looks like all the links are valid (green) but if you try clicking on a tif link, you'll just get github symlink.

By using the tsv from this PR: https://proxy-idr-ap1.dundee.ac.uk/webclient/img_detail/12689244/?check_links=true&tsv=https://raw.githubusercontent.com/will-moore/idr.openmicroscopy.org/refs/heads/download_urls_github_ftp/_data/download_urls.tsv all the tiff links are correct and will download the tif for you.

Unfortunately, only those 3 studies were amenable to this approach. Others are too unpredictable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants