Fix idr0106 to download from ftp instead of github - #225
Conversation
6691525 to
41b460f
Compare
|
Test:
Will revert idr0052 change... |
This reverts commit 41b460f.
|
What is needed here please ? Testing ? How ? |
|
Testing, yes please, using On the By using the tsv from this PR: https://proxy-idr-ap1.dundee.ac.uk/webclient/img_detail/12689244/?check_links=true&tsv=https://raw.githubusercontent.com/will-moore/idr.openmicroscopy.org/refs/heads/download_urls_github_ftp/_data/download_urls.tsv all the tiff links are correct and will download the tif for you. Unfortunately, only those 3 studies were amenable to this approach. Others are too unpredictable. |
For all "github" studies, where the
companion.omefile or.patternfile is on github and the rest of the files are available on ftp, we have made sure that thecompanion.omefile or.patternfile has the correct download url, but the tiff files do NOT get the correct URL.This is probably the wrong way to go, as most users probably care more about downloading the tiff files that the pattern/companion file.
For some studies (idr0075, idr0079, idr0106) the
client_pathsin the Filesets are consistent with respect to download URLs on ftp. So we can get a download URL via simple replace.To test, we can open the tsv from this PR and check those rows with:
https://proxy-idr-ap1.dundee.ac.uk/download_urls/?tsv=https://raw.githubusercontent.com/will-moore/idr.openmicroscopy.org/refs/heads/download_urls_github_ftp/_data/download_urls.tsv
We can also use the tsv for individual images. E.g. https://proxy-idr-ap1.dundee.ac.uk/webclient/img_detail/12689244/?check_links=true&tsv=https://raw.githubusercontent.com/will-moore/idr.openmicroscopy.org/refs/heads/download_urls_github_ftp/_data/download_urls.tsv - all the tif links are now "green", but companion.ome is not.
Other studies are more complex:
Known issues (GitHub studies not fixed by this PR):
/uod/idr/filesets/idr0100-capar-myelin/20201022-ftp/experimentA/Sample_Myelin_Images1/Sample1_Axon.tifdata/idr-metadata/idr0099-jain-beetlelightsheet/experimentA/20210208-patterns/9-3-15_Histone-eGFP/TP_T0_Chgreen_Ill0_Ang0,1,2.tifto https://ftp.ebi.ac.uk/pub/databases/IDR/idr0099-jain-beetlelightsheet/20201001-ftp/Akanksha_Jain_9-3-15_Histone-eGFP/TP0_Chgreen_Ill0_Ang0,1,2.tif BUT alsodata/idr-metadata/idr0099-jain-beetlelightsheet/experimentA/20210128-companions/22-06-16_Tc-Squash-eGFP/TP0_Ch0_Ill0_Ang1,2,3,4,5.tifto https://ftp.ebi.ac.uk/pub/databases/IDR/idr0099-jain-beetlelightsheet/20210128-ftp/TP0_Ch0_Ill0_Ang1,2,3,4,5.tif - NO simple replace, - same image:data/idr-metadata/idr0099-jain-beetlelightsheet/experimentA/20210128-companions/22-06-16_Tc-Squash-eGFP/TP212_Ch0_Ill0_Ang1,2,3,4,5.tifto https://ftp.ebi.ac.uk/pub/databases/IDR/idr0099-jain-beetlelightsheet/20201001-ftp/Akanksha_Jain_22-06-16_Tc-Squash-eGFP/TP212_Ch0_Ill0_Ang1,2,3,4,5.tif NB: https://ftp.ebi.ac.uk/pub/databases/IDR/idr0099-jain-beetlelightsheet/20210128-ftp/ only has 11 tiffs, all the rest are under https://ftp.ebi.ac.uk/pub/databases/IDR/idr0099-jain-beetlelightsheet/20201001-ftp/