Test: Only Show Correction of Points if Available

See: https://mantis.ilias.de/view.php?id=48302

Author: kergomard

components/ILIAS/Test/classes/class.ilTestCorrectionsGUI.php

@@ -389,7 +389,7 @@ protected function checkQuestion(): bool
             return false;
         }
 
-        if (!$this->supportsAdjustment($this->question_gui)) {
+        if (!$this->question_gui?->supportsAdjustment()) {
             return false;
         }
 
@@ -460,9 +460,7 @@ protected function getQuestions(): array
         return array_reduce(
             $this->test_obj->getTestQuestions(),
             function (array $c, array $v): array {
-                $question_gui = $this->getQuestionGUI($v['question_id']);
-
-                if (!$this->supportsAdjustment($question_gui)) {
+                if (!$this->getQuestionGUI($v['question_id'])?->supportsAdjustment()) {
                     return $c;
                 }
 
@@ -472,19 +470,4 @@ function (array $c, array $v): array {
             []
         );
     }
-
-    /**
-     * Returns if the given question object support scoring adjustment.
-     *
-     * @param $question_object assQuestionGUI
-     *
-     * @return bool True, if relevant interfaces are implemented to support scoring adjustment.
-     */
-    protected function supportsAdjustment(\assQuestionGUI $question_object): bool
-    {
-        return ($question_object instanceof ilGuiQuestionScoringAdjustable
-                || $question_object instanceof ilGuiAnswerScoringAdjustable)
-            && ($question_object->getObject() instanceof ilObjQuestionScoringAdjustable
-                || $question_object->getObject() instanceof ilObjAnswerScoringAdjustable);
-    }
 }

components/ILIAS/Test/src/Questions/Presentation/QuestionsTableActions.php

@@ -20,6 +20,7 @@
 
 namespace ILIAS\Test\Questions\Presentation;
 
+use ILIAS\Test\Questions\Properties\Properties;
 use ILIAS\Test\Questions\Properties\Repository as TestQuestionsRepository;
 use ILIAS\Test\ResponseHandler;
 use ILIAS\UI\Factory as UIFactory;
@@ -75,7 +76,8 @@ public function __construct(
     }
 
     public function setDisabledActions(
-        OrderingRow $row
+        OrderingRow $row,
+        Properties $record
     ): OrderingRow {
         $disable_default_actions = $this->is_in_test_with_random_question_set
             || $this->is_in_test_with_results;
@@ -87,7 +89,11 @@ public function setDisabledActions(
         ->withDisabledAction(self::ACTION_EDIT_PAGE, $disable_default_actions)
         ->withDisabledAction(
             self::ACTION_ADJUST,
-            !$this->is_adjusting_questions_with_results_allowed || !$this->is_in_test_with_results
+            !$this->is_adjusting_questions_with_results_allowed
+                || !$this->is_in_test_with_results
+                || !\assQuestion::instantiateQuestionGUI(
+                    $record->getGeneralQuestionProperties()->getQuestionId()
+                )->supportsAdjustment()
         )->withDisabledAction(self::ACTION_FEEDBACK, $disable_default_actions)
         ->withDisabledAction(self::ACTION_PRINT_ANSWERS, !$this->is_in_test_with_results)
         ->withDisabledAction(

components/ILIAS/TestQuestionPool/classes/class.assQuestionGUI.php

@@ -2067,6 +2067,14 @@ public function buildFileDownloadLink(): string
         return $this->ctrl->getLinkTargetByClass(ilObjTestGUI::class, 'downloadFile');
     }
 
+    public function supportsAdjustment(): bool
+    {
+        return ($this instanceof ilGuiQuestionScoringAdjustable
+                || $this instanceof ilGuiAnswerScoringAdjustable)
+            && ($this->getObject() instanceof ilObjQuestionScoringAdjustable
+                || $this->getObject() instanceof ilObjAnswerScoringAdjustable);
+    }
+
     protected function resetSavedPreviewSession(): void
     {
         $this->preview_session = new ilAssQuestionPreviewSession(