FIX plots not being rendered in 'Choice of n_components in the unsupervised case' notebook - #881
Merged
Merged
Conversation
added 2 commits
August 13, 2026 15:13
…rvised case' notebook
ArturoAmorQ
added a commit
to probabl-ai/scikit-learn-course
that referenced
this pull request
Aug 14, 2026
ArturoAmorQ
added a commit
to probabl-ai/scikit-learn-course
that referenced
this pull request
Aug 14, 2026
github-actions Bot
pushed a commit
to Mahendra687/scikit-learn-mooc
that referenced
this pull request
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #876.
The
_ = axes[1].set_title(...)pattern used everywhere in the mooc doesn't render anything in the Choice of n_components in the unsupervised case notebook.After some investigation, the issue seems to be that
skrub.TableReportgenerates its per-column sparkline SVGs using matplotlib'src_contextinternally (though patched in skrub#1172, skrub 0.4.1). Entering and exitingrc_contextinside a Jupyter kernel can silently disable that post-execute hook, then every subsequent cell in that execution loses auto inline display. This is a known, still-open matplotlib bug (matplotlib#25041). As the underlying matplotlib issue has not being fixed upstream, it can resurface with different matplotlib/skrub version combinations.The proposed fix is then to simply use
plt.show()as it doesn't depend on that hook. It explicitly renders each open figure, so it works whether or not the hook is still installed.