Skip to content

Use same max_depth when comparing gbdt and hgbt - #882

Open
ArturoAmorQ wants to merge 1 commit into
INRIA:mainfrom
ArturoAmorQ:hgbt_vs_gbdt
Open

Use same max_depth when comparing gbdt and hgbt#882
ArturoAmorQ wants to merge 1 commit into
INRIA:mainfrom
ArturoAmorQ:hgbt_vs_gbdt

Conversation

@ArturoAmorQ

Copy link
Copy Markdown
Collaborator

As flagged in the forum, HistGradientBoostingRegressor and GradientBoostingRegressor are explicitly aligned on the max number of iterations, but the default values of other important parameters, such as max_depth, are very different (HGBT builds full trees and GBDT builds shallow trees).

As is, the unfair comparison may make HistGradientBoostingRegressor look slower than GradientBoostingRegressor, depending on the CPU (see this issue).

To keep the message of this notebook simple, this PR modifies max_depth only, as it impacts the fit time the most.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants