Better node display - #137
Open
benwr wants to merge 8 commits into
Open
Conversation
ISibboI
requested changes
Jun 4, 2023
ISibboI
left a comment
ISibboI
left a comment
Owner
There was a problem hiding this comment.
Thank you a lot, this looks great! Can you add some tests with some simple and more complicated expressions whose Display output parses into the same operator tree?
Contributor
Author
|
How would you feel about adding a dev dependency on quickcheck? I might want to randomly generate operator trees and check that they round-trip to the same trees. |
Owner
|
I am totally fine with new dev dependencies. |
ISibboI
force-pushed
the
better_node_display_rebased
branch
from
June 17, 2023 09:53
b56a199 to
3593b8f
Compare
ISibboI
previously approved these changes
Jun 27, 2023
Owner
|
It seems like propagating the precision does not work. We can either just not support floating point precision, or we fix that somehow. |
ISibboI
force-pushed
the
main
branch
6 times, most recently
from
October 11, 2024 15:01
e4a8571 to
6608b16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the Display instance for Node. Previously it printed a simple pre-order traversal, which was sometimes ambiguous because e.g. for nested n-ary functions it wasn't clear which things were arguments.
Now, this should produce a visual that is (a) unique, and (b) can be parsed back into an equivalent Node.