Skip to content

Commit 9232407

Browse files
committed
refactor: rename On-Event to Event
1 parent f0622ac commit 9232407

4 files changed

Lines changed: 26 additions & 26 deletions

File tree

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,10 +133,10 @@ Handle sorting and filtering events:
133133
```razor
134134
<IgbGridLite Data="@employees"
135135
Columns="@columns"
136-
OnSorting="@HandleSorting"
137-
OnSorted="@HandleSorted"
138-
OnFiltering="@HandleFiltering"
139-
OnFiltered="@HandleFiltered" />
136+
Sorting="@HandleSorting"
137+
Sorted="@HandleSorted"
138+
Filtering="@HandleFiltering"
139+
Filtered="@HandleFiltered" />
140140
141141
@code {
142142
private void HandleSorting(IgbGridLiteSortingEventArgs e)

demo/GridLite.DemoApp/Components/Pages/Home.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
SortConfiguration="@sortConfiguration" Columns="cols"
55
SortExpressions="@initialSort"
66
FilterExpressions="@initialFilter"
7-
OnSorting="HandleSorting" OnSorted="HandleSorted"
8-
OnFiltering="HandleFiltering" OnFiltered="HandleFiltered">
7+
Sorting="HandleSorting" Sorted="HandleSorted"
8+
Filtering="HandleFiltering" Filtered="HandleFiltered">
99

1010
</IgbGridLite>
1111

src/IgniteUI.Blazor.GridLite/IgbGridLite.razor.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,14 @@ public partial class IgbGridLite<TItem> : ComponentBase, IDisposable where TItem
7575
/// The expression can be modified prior to the operation running.
7676
/// </remarks>
7777
[Parameter]
78-
public EventCallback<IgbGridLiteSortingEventArgs> OnSorting { get; set; }
78+
public EventCallback<IgbGridLiteSortingEventArgs> Sorting { get; set; }
7979

8080
/// <summary>
8181
/// Fires when a sort operation initiated through the UI has completed.
8282
/// Returns the sort expression used for the operation.
8383
/// </summary>
8484
[Parameter]
85-
public EventCallback<IgbGridLiteSortedEventArgs> OnSorted { get; set; }
85+
public EventCallback<IgbGridLiteSortedEventArgs> Sorted { get; set; }
8686

8787
/// <summary>
8888
/// Fires when filtering is initiated through the UI.
@@ -92,14 +92,14 @@ public partial class IgbGridLite<TItem> : ComponentBase, IDisposable where TItem
9292
/// The expression can be modified prior to the operation running.
9393
/// </remarks>
9494
[Parameter]
95-
public EventCallback<IgbGridLiteFilteringEventArgs> OnFiltering { get; set; }
95+
public EventCallback<IgbGridLiteFilteringEventArgs> Filtering { get; set; }
9696

9797
/// <summary>
9898
/// Fires when a filter operation initiated through the UI has completed.
9999
/// Returns the filter state for the affected column.
100100
/// </summary>
101101
[Parameter]
102-
public EventCallback<IgbGridLiteFilteredEventArgs> OnFiltered { get; set; }
102+
public EventCallback<IgbGridLiteFilteredEventArgs> Filtered { get; set; }
103103

104104
/// <summary>
105105
/// Fires when <see cref="RenderAsync"/> completes
@@ -210,10 +210,10 @@ private object GetEventFlags()
210210
{
211211
return new
212212
{
213-
hasSorting = OnSorting.HasDelegate,
214-
hasSorted = OnSorted.HasDelegate,
215-
hasFiltering = OnFiltering.HasDelegate,
216-
hasFiltered = OnFiltered.HasDelegate
213+
hasSorting = Sorting.HasDelegate,
214+
hasSorted = Sorted.HasDelegate,
215+
hasFiltering = Filtering.HasDelegate,
216+
hasFiltered = Filtered.HasDelegate
217217
};
218218
}
219219

src/IgniteUI.Blazor.GridLite/Internal/JSHandler.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ public void Dispose()
2929
/// </summary>
3030
/// <param name="sortExpression">The sort expression from JavaScript</param>
3131
/// <remarks>
32-
/// Will execute <see cref="IgbGridLite{TItem}.OnSorting"/>
32+
/// Will execute <see cref="IgbGridLite{TItem}.Sorting"/>
3333
/// </remarks>
3434
[JSInvokable]
3535
public async Task<bool> JSSorting(JsonElement sortExpression)
3636
{
37-
if (!GridReference.OnSorting.HasDelegate)
37+
if (!GridReference.Sorting.HasDelegate)
3838
return false; // Don't cancel
3939

4040
try
@@ -48,7 +48,7 @@ public async Task<bool> JSSorting(JsonElement sortExpression)
4848
Cancel = false
4949
};
5050

51-
await GridReference.OnSorting.InvokeAsync(eventArgs);
51+
await GridReference.Sorting.InvokeAsync(eventArgs);
5252

5353
// Return true to cancel the operation
5454
return eventArgs.Cancel;
@@ -64,12 +64,12 @@ public async Task<bool> JSSorting(JsonElement sortExpression)
6464
/// </summary>
6565
/// <param name="sortExpression">The sort expression from JavaScript</param>
6666
/// <remarks>
67-
/// Will execute <see cref="IgbGridLite{TItem}.OnSorted"/>
67+
/// Will execute <see cref="IgbGridLite{TItem}.Sorted"/>
6868
/// </remarks>
6969
[JSInvokable]
7070
public void JSSorted(JsonElement sortExpression)
7171
{
72-
if (!GridReference.OnSorted.HasDelegate)
72+
if (!GridReference.Sorted.HasDelegate)
7373
return;
7474

7575
try
@@ -82,7 +82,7 @@ public void JSSorted(JsonElement sortExpression)
8282
Expression = expression
8383
};
8484

85-
GridReference.OnSorted.InvokeAsync(eventArgs);
85+
GridReference.Sorted.InvokeAsync(eventArgs);
8686
}
8787
catch
8888
{
@@ -95,20 +95,20 @@ public void JSSorted(JsonElement sortExpression)
9595
/// </summary>
9696
/// <param name="filteringEvent">The filtering event details from JavaScript</param>
9797
/// <remarks>
98-
/// Will execute <see cref="IgbGridLite{TItem}.OnFiltering"/>
98+
/// Will execute <see cref="IgbGridLite{TItem}.Filtering"/>
9999
/// </remarks>
100100
[JSInvokable]
101101
public async Task<bool> JSFiltering(JsonElement filteringEvent)
102102
{
103-
if (!GridReference.OnFiltering.HasDelegate)
103+
if (!GridReference.Filtering.HasDelegate)
104104
return false; // Don't cancel
105105

106106
try
107107
{
108108
var eventData = JsonSerializer.Deserialize<IgbGridLiteFilteringEventArgs>(
109109
filteringEvent.GetRawText());
110110

111-
await GridReference.OnFiltering.InvokeAsync(eventData);
111+
await GridReference.Filtering.InvokeAsync(eventData);
112112

113113
// IgbGridLiteFilteringEventArgs doesn't have a Cancel property in the TypeScript definition
114114
// but you could add it if needed
@@ -125,20 +125,20 @@ public async Task<bool> JSFiltering(JsonElement filteringEvent)
125125
/// </summary>
126126
/// <param name="filteredEvent">The filtered event details from JavaScript</param>
127127
/// <remarks>
128-
/// Will execute <see cref="IgbGridLite{TItem}.OnFiltered"/>
128+
/// Will execute <see cref="IgbGridLite{TItem}.Filtered"/>
129129
/// </remarks>
130130
[JSInvokable]
131131
public void JSFiltered(JsonElement filteredEvent)
132132
{
133-
if (!GridReference.OnFiltered.HasDelegate)
133+
if (!GridReference.Filtered.HasDelegate)
134134
return;
135135

136136
try
137137
{
138138
var eventData = JsonSerializer.Deserialize<IgbGridLiteFilteredEventArgs>(
139139
filteredEvent.GetRawText());
140140

141-
GridReference.OnFiltered.InvokeAsync(eventData);
141+
GridReference.Filtered.InvokeAsync(eventData);
142142
}
143143
catch
144144
{

0 commit comments

Comments
 (0)