Sorting API refactor - #9
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 20102296012Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR refactors the sorting API to improve naming consistency and simplify the configuration interface. The changes rename types and properties to better reflect their purpose while removing the triState option by making it always enabled.
Key changes:
- Renamed sorting-related types and properties throughout the codebase for better clarity (
SortExpression→SortingExpression,sortConfiguration→sortingOptions) - Simplified sorting configuration by replacing boolean
multipleproperty with string-basedmodeproperty and removingtriStateoption - Removed redundant test cases for non-tri-state sorting scenarios
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/operations/sort/types.ts | Renamed BaseSortExpression and SortExpression types to BaseSortingExpression and SortingExpression |
| src/internal/types.ts | Renamed GridSortConfiguration to GridLiteSortingOptions and replaced multiple/triState booleans with mode string property |
| src/components/grid.ts | Updated grid component to use renamed types and properties (sortingOptions, sortingExpressions) |
| src/operations/sort.ts | Updated to use renamed SortingExpression type |
| src/controllers/sort.ts | Updated sort controller to use new API and hardcoded tri-state behavior |
| src/components/header.ts | Updated header component to check sorting mode using new API |
| src/index.ts | Updated exported type names to reflect API changes |
| test/data-operation/sort.test.ts | Updated test to use renamed SortingExpression type |
| test/data-operation/sort-ui.test.ts | Updated tests to use new sorting options API and removed non-tri-state test cases |
| test/grid.properties.test.ts | Updated property tests to use renamed sortingExpressions property |
| test/utils/grid-fixture.ts | Updated test fixture to use renamed SortingExpression type |
| CHANGELOG.md | Added changelog documenting all breaking changes in the sorting API refactor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
damyanpetev
force-pushed
the
dpetev/sorting-api
branch
from
December 10, 2025 14:36
483835c to
85a1310
Compare
damyanpetev
marked this pull request as ready for review
December 10, 2025 14:37
rkaraivanov
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.