feat(*): re-implementing theme handler on better base - #1256
Open
ChronosSF wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
There is a confirmed runtime bug in resolveMode() (optional chaining misuse) and an avoidable performance regression due to an unconditional dynamic import.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds a message-driven theme handler so sample pages can be re-themed dynamically when embedded in the docs site iframe, by retargeting theme <link data-ig-theme> stylesheets and syncing Ignite UI Web Components’ shadow-style theming.
Changes:
- Introduces
initSampleThemeListener()to validatepostMessagesenders and apply theme/mode updates (including “system” mode). - Retargets existing theme
<link data-ig-theme>URLs to swap variant/theme CSS at runtime, then callsconfigureTheme()to re-adopt shadow styles. - Wires the theme listener into the sample page layout so it runs on every sample page.
File summaries
| File | Description |
|---|---|
| src/utils/sample-theme.ts | Adds the postMessage listener, origin validation, CSS link retargeting, and shadow-style re-adoption via configureTheme(). |
| src/layouts/SampleLayout.astro | Initializes the sample theme listener on sample pages so docs can drive theme changes in an iframe. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.