Skip to content

feat(*): re-implementing theme handler on better base - #1256

Open
ChronosSF wants to merge 3 commits into
vnextfrom
sstoychev/theme-widget-handler
Open

feat(*): re-implementing theme handler on better base#1256
ChronosSF wants to merge 3 commits into
vnextfrom
sstoychev/theme-widget-handler

Conversation

@ChronosSF

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

There is a confirmed runtime bug in resolveMode() (optional chaining misuse) and an avoidable performance regression due to an unconditional dynamic import.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adds a message-driven theme handler so sample pages can be re-themed dynamically when embedded in the docs site iframe, by retargeting theme <link data-ig-theme> stylesheets and syncing Ignite UI Web Components’ shadow-style theming.

Changes:

  • Introduces initSampleThemeListener() to validate postMessage senders and apply theme/mode updates (including “system” mode).
  • Retargets existing theme <link data-ig-theme> URLs to swap variant/theme CSS at runtime, then calls configureTheme() to re-adopt shadow styles.
  • Wires the theme listener into the sample page layout so it runs on every sample page.
File summaries
File Description
src/utils/sample-theme.ts Adds the postMessage listener, origin validation, CSS link retargeting, and shadow-style re-adoption via configureTheme().
src/layouts/SampleLayout.astro Initializes the sample theme listener on sample pages so docs can drive theme changes in an iframe.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/utils/sample-theme.ts
Comment thread src/utils/sample-theme.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants