fix: pass release tag_name via env instead of interpolating it into run (#81)

* fix: pass release tag_name via env instead of interpolating it into run

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: quote redirections in release version step to satisfy shellcheck

The quality gate introduced by the Go profile adoption (#65) fails on the
pre-existing release.yml: SC2086 (unquoted $GITHUB_OUTPUT redirects) and
SC2129 (individual redirects instead of a grouped one). Group the GITHUB_OUTPUT
writes and quote the variable; the debug echo stays outside the group so it
keeps printing to the job log.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: ivanasabi <ivanasabi@ext.inditex.com>

---------

Signed-off-by: ivanasabi <ivanasabi@ext.inditex.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: enriqueavi <146724635+enriqueavindi@users.noreply.github.com>

Author: 3 people

.github/workflows/release.yml

@@ -32,41 +32,45 @@ jobs:
       - name: 📝 Load Operator version
         id: version
         run: |
-          echo "version=$(make print-VERSION | cut -d'=' -f2)" >> $GITHUB_OUTPUT
-          echo "values_version=$(yq '.deployment.image.tag' chart/values.yaml)" >> $GITHUB_OUTPUT
-          echo "chart_version=$(yq '.appVersion' chart/Chart.yaml)" >> $GITHUB_OUTPUT
-          echo "catalog_version=$(yq '.spec.image' deploy/catalog_source.yaml | cut -d':' -f2)" >> $GITHUB_OUTPUT
-          echo $GITHUB_OUTPUT
+          {
+            echo "version=$(make print-VERSION | cut -d'=' -f2)"
+            echo "values_version=$(yq '.deployment.image.tag' chart/values.yaml)"
+            echo "chart_version=$(yq '.appVersion' chart/Chart.yaml)"
+            echo "catalog_version=$(yq '.spec.image' deploy/catalog_source.yaml | cut -d':' -f2)"
+          } >> "$GITHUB_OUTPUT"
+          echo "$GITHUB_OUTPUT"
 
   check:
     name: 🔎 Check versions
     needs: release
     runs-on: ubuntu-latest
     steps:
       - name: 🔎 Check versions
+        env:
+          RELEASE_TAG_NAME: ${{ github.event.release.tag_name }}
         run: |
           echo "version: ${{ needs.release.outputs.version }}"
           echo "values_version: ${{ needs.release.outputs.values_version }}"
           echo "chart_version: ${{ needs.release.outputs.chart_version }}"
-          echo "tag_name: ${{ github.event.release.tag_name }}"
+          echo "tag_name: $RELEASE_TAG_NAME"
           echo "catalog_version: ${{ needs.release.outputs.catalog_version }}"
 
-          if [ "${{ github.event.release.tag_name }}" != "${{ needs.release.outputs.version }}" ]; then
+          if [ "$RELEASE_TAG_NAME" != "${{ needs.release.outputs.version }}" ]; then
             echo "Version in Makefile does not match release tag"
             exit 1
           fi
 
-          if [ "${{ github.event.release.tag_name }}" != "${{ needs.release.outputs.values_version }}" ]; then
+          if [ "$RELEASE_TAG_NAME" != "${{ needs.release.outputs.values_version }}" ]; then
             echo "Version in chart/values.yaml does not match release tag"
             exit 1
           fi
 
-          if [ "${{ github.event.release.tag_name }}" != "${{ needs.release.outputs.chart_version }}" ]; then
+          if [ "$RELEASE_TAG_NAME" != "${{ needs.release.outputs.chart_version }}" ]; then
             echo "Version in chart/Chart.yaml does not match release tag"
             exit 1
           fi
 
-          if [ "${{ github.event.release.tag_name }}" != "${{ needs.release.outputs.catalog_version }}" ]; then
+          if [ "$RELEASE_TAG_NAME" != "${{ needs.release.outputs.catalog_version }}" ]; then
             echo "Version in deploy/catalog_source.yaml does not match release tag"
             exit 1
           fi