Cleanup: drop unused locals and fix the container return annotation

Author: Insality

druid/base/drag.lua

@@ -185,7 +185,7 @@ function M:on_input(action_id, action)
 	if touch.released and self.is_touch then
 		if action.touch then
 			-- Mobile
-			self:_on_touch_release(action_id, action, touch)
+			self:_on_touch_release(action, touch)
 		else
 			-- PC
 			self:_end_touch(touch)
@@ -376,10 +376,9 @@ end
 
 ---Process on touch release. We should to find, if any other
 ---touches exists to switch to another touch.
----@param action_id hash Action id from on_input
 ---@param action table Action from on_input
 ---@param touch table Touch action
-function M:_on_touch_release(action_id, action, touch)
+function M:_on_touch_release(action, touch)
 	if #action.touch >= 2 then
 		-- Find next unpressed touch
 		local next_touch

druid/base/scroll.lua

@@ -152,7 +152,7 @@ function M:update(dt)
 	end
 
 	if self.drag.is_drag then
-		self:_update_hand_scroll(dt)
+		self:_update_hand_scroll()
 	else
 		self:_update_free_scroll(dt)
 	end
@@ -768,7 +768,7 @@ function M:_update_free_scroll(dt)
 end
 
 
-function M:_update_hand_scroll(dt)
+function M:_update_hand_scroll()
 	if self.is_animate then
 		self:_cancel_animate()
 	end

druid/base/static_grid.lua

@@ -306,7 +306,7 @@ end
 ---@return vector3[] positions All grid node positions
 function M:get_all_pos()
 	local result = {}
-	for i, node in pairs(self.nodes) do
+	for _, node in pairs(self.nodes) do
 		table.insert(result, gui.get_position(node))
 	end
 

druid/base/text.lua

@@ -363,7 +363,7 @@ function M:_update_text_area_size()
 		local is_fit = self:_is_fit_info_area(metrics)
 		local step = is_fit and self.style.ADJUST_SCALE_DELTA or -self.style.ADJUST_SCALE_DELTA
 
-		for i = 1, self.style.ADJUST_STEPS do
+		for _ = 1, self.style.ADJUST_STEPS do
 			-- Grow down to check if we fit
 			if step < 0 and is_fit then
 				break

druid/custom/rich_text/module/rt.lua

@@ -126,7 +126,6 @@ local function get_image_metrics(word, settings)
 	gui.play_flipbook(node, hash(word.image.anim))
 
 	local node_size = gui.get_size(node)
-	local aspect = node_size.x / node_size.y
 	node_size.x = word.image.width or node_size.x
 	node_size.y = word.image.height or node_size.y
 

druid/extended/container.lua

@@ -291,7 +291,7 @@ function M:add_container(node_or_container, mode, on_resize_callback)
 	---@cast node node
 	node = self:get_node(node)
 
-	container = container or self.druid:new(M, node, mode)
+	container = container or self.druid:new(M, node, mode) --[[@as druid.container]]
 	container:set_parent_container(self)
 	if on_resize_callback then
 		container.on_size_changed:subscribe(on_resize_callback)

druid/extended/slider.lua

@@ -107,9 +107,9 @@ function M:on_input(action_id, action)
 
 	if not self.is_drag and self._input_node and gui.pick_node(self._input_node, action.x, action.y) then
 		if action.pressed and gui.screen_to_local then
+			-- Refreshed for the drag delta below, screen_to_local does not need it
 			self._scene_scale = helper.get_scene_scale(self.node)
 			self.pos = gui.screen_to_local(self.node, vmath.vector3(action.screen_x, action.screen_y, 0))
-			-- gui.screen_to_local already accounts for the scene scale, no need to divide it again
 			self.pos.x = helper.clamp(self.pos.x, self.start_pos.x, self.end_pos.x)
 			self.pos.y = helper.clamp(self.pos.y, self.start_pos.y, self.end_pos.y)