Skip to content

fix(viewmodel): keep useIndexedValues in AndroidParametersHolder #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xZhangKe wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −3
Open

fix(viewmodel): keep useIndexedValues in AndroidParametersHolder #2399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...ore-viewmodel/src/commonMain/kotlin/org/koin/viewmodel/factory/AndroidParametersHolder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,18 @@ import org.koin.core.parameter.ParametersDefinition
import org.koin.core.parameter.ParametersHolder
import kotlin.reflect.KClass

class AndroidParametersHolder(
initialValues: ParametersDefinition? = null,
class AndroidParametersHolder private constructor(
initialValues: ParametersHolder?,
private val extras: CreationExtras,
) : ParametersHolder(initialValues?.invoke()?.values?.toMutableList() ?: mutableListOf()) {
) : ParametersHolder(
_values = initialValues?.values?.toMutableList() ?: mutableListOf(),
useIndexedValues = initialValues?.useIndexedValues,
) {
Comment thread
0xZhangKe marked this conversation as resolved.

constructor(
initialValues: ParametersDefinition? = null,
extras: CreationExtras,
) : this(initialValues?.invoke(), extras)

override fun <T> elementAt(i: Int, clazz: KClass<*>): T {
return createSavedStateHandleOrElse(clazz) { super.elementAt(i, clazz) }
Expand Down