Support unloadKoinModules() for Lazy modules - #2460
Open
cpaleop wants to merge 2 commits into
Open
Conversation
cpaleop
commented
Aug 10, 2026
| * No-op if the lazy module has not been initialized yet, since in that case | ||
| * no definitions were ever registered for it. | ||
| * | ||
| * @author Chris Paleopanos |
Contributor
Author
There was a problem hiding this comment.
I see the authors are now mentioned in a disconnected kDoc right after the class signature. This doesn't make sense, so I added it here.
Let me know though if you want me to move it above 🙏🏻
cpaleop
commented
Aug 10, 2026
| * | ||
| * @author Chris Paleopanos | ||
| */ | ||
| fun loadKoinModules(modules: List<Lazy<Module>>) = KoinPlatformTools.defaultContext().loadKoinModules(modules.map { it.value }) |
Contributor
Author
There was a problem hiding this comment.
I also added support for this overload, just to keep parity between eager and lazy APIs
cpaleop
commented
Aug 10, 2026
| class UnloadTarget | ||
| class UnloadTarget2 | ||
|
|
||
| class LoadLazyModulesTest { |
Contributor
Author
There was a problem hiding this comment.
I couldn't find a way to test the case where:
- App calls
unloadKoinModules(..) - Some of the Lazy modules have not been initialized yet
- Verify that only the initialized modules are being unloaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #2459
This PR provides support for unloading
LazyModules out-of-the-box.The existing API (
unloadKoinModules(modules: List<Module>)) can also be used for this, but it requires maintaining initialization/realization logic on consumer side. More about that in the linked issue.