Commit e55e36a
committed
BUG: Fix ASV harness against real ITK build + CLI reality
Changes surfaced during end-to-end smoke-test against a local ITK build
with Module_PerformanceBenchmarking=ON:
asv.conf.json
- repo: '.' → 'itk-repo' (symlink the caller places into the harness
pointing at the ITK source tree). Required so --set-commit-hash
can validate SHAs against git. The consuming CI workflow and the
local smoke-test recipe in README-asv.md both create this symlink.
- branches: adjusted to 'origin/master' (the ITK branch whose tip we
track for publish's time-series graph).
- install_command: installs from relative 'python/' path rather than
{build_dir}, since {build_dir} now refers to ITK checkouts.
python/itk_perf_shim/registry.py
- Executable names: itkCopyIterationBenchmark → CopyIterationBenchmark
and the same for VectorIterationBenchmark. The add_executable()
target name drops the 'itk' prefix present on the source file.
- CLI: Core benchmarks take 'timingsFile iterations imageSize', not
just 'timingsFile iterations'. Fixed imageSize to 128 (matching
the in-tree CTest registrations) and iteration counts to 25 / 50.
python/itk_perf_shim/runner.py
- Input fixture: brainweb165a10f17.mha (the real ExternalData
object) replaces the placeholder OAS1 filename I guessed
pre-build-validation.
.gitignore
- Ignore the 'itk-repo' symlink.
Smoke-test result (single-machine, same-binary, labeled as two
different ITK SHAs to exercise asv compare):
core.track_copy_iteration 10.5ms → 10.2ms ratio 0.98
core.track_vector_iteration 4.98ms → 4.61ms ratio 0.93
filtering.track_binary_add 5.39ms → 5.09ms ratio 0.94
filtering.track_gradient_magnitude 48.3ms → 47.3ms ratio 0.98
filtering.track_median 321ms → 312ms ratio 0.97
All within expected per-run jitter; exercise validates discovery,
shim invocation, probe-JSON parsing, and asv compare output.1 parent e33a735 commit e55e36a
4 files changed
Lines changed: 12 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
23 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
0 commit comments