Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>

Author: Copilot

Directory.Packages.props

@@ -1,20 +1,20 @@
-<Project>
-  <PropertyGroup>
-    <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
-    <CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled>
-  </PropertyGroup>
-  <ItemGroup>
-    <PackageVersion Include="coverlet.collector" Version="8.0.0" />
-    <PackageVersion Include="IntelliTect.Analyzers" Version="0.1.8" />
-    <PackageVersion Include="Microsoft.Build.Locator" Version="1.7.8" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.0.0" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="5.0.0" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.103" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="5.0.0" />
-    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
-    <PackageVersion Include="MSTest.TestAdapter" Version="4.1.0" />
-    <PackageVersion Include="MSTest.TestFramework" Version="4.1.0" />
-    <PackageVersion Include="System.CommandLine.DragonFruit" Version="0.4.0-alpha.23407.1" />
-  </ItemGroup>
-</Project>
+<Project>
+  <PropertyGroup>
+    <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
+    <CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled>
+  </PropertyGroup>
+  <ItemGroup>
+    <PackageVersion Include="coverlet.collector" Version="8.0.0" />
+    <PackageVersion Include="IntelliTect.Analyzers" Version="0.1.8" />
+    <PackageVersion Include="Microsoft.Build.Locator" Version="1.7.8" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.0.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="5.0.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.103" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="5.0.0" />
+    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
+    <PackageVersion Include="MSTest.TestAdapter" Version="4.1.0" />
+    <PackageVersion Include="MSTest.TestFramework" Version="4.1.0" />
+    <PackageVersion Include="System.CommandLine.DragonFruit" Version="0.4.0-alpha.23407.1" />
+  </ItemGroup>
+</Project>

IntelliTect.Analyzer/IntelliTect.Analyzer/Analyzers/NamingMethodPascal.cs

@@ -107,7 +107,8 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context)
 
         private static bool IsTestMethod(IMethodSymbol methodSymbol)
         {
-            // Test framework namespaces - checking namespace is more flexible than specific attribute names
+            // Test framework namespaces - any method decorated with an attribute from these namespaces
+            // is considered a test method and exempt from PascalCase validation
             string[] testFrameworkNamespaces = 
             [
                 "Xunit",                                    // xUnit (note: namespace is "Xunit", not "XUnit")
@@ -116,7 +117,8 @@ private static bool IsTestMethod(IMethodSymbol methodSymbol)
                 "TUnit.Core"                                // TUnit
             ];
 
-            // Fallback attribute names for test environments where namespace metadata may be incomplete
+            // Fallback attribute names - needed because our test infrastructure (DiagnosticVerifier)
+            // doesn't add references to test framework assemblies, so ContainingNamespace would be null
             string[] commonTestAttributeNames =
             [
                 "TestMethod", "TestMethodAttribute",        // MSTest
@@ -135,15 +137,15 @@ private static bool IsTestMethod(IMethodSymbol methodSymbol)
                     return false;
                 }
 
-                // Check namespace first (more robust for production code)
+                // Check namespace first (works in production with proper assembly references)
                 string containingNamespace = attribute.AttributeClass.ContainingNamespace?.ToDisplayString();
                 if (containingNamespace != null && 
                     testFrameworkNamespaces.Any(ns => containingNamespace.StartsWith(ns, StringComparison.Ordinal)))
                 {
                     return true;
                 }
 
-                // Fallback: check attribute name for common test attributes
+                // Fallback: check attribute name (needed for test environment)
                 string attributeName = attribute.AttributeClass.Name;
                 return commonTestAttributeNames.Contains(attributeName);
             });