Repository navigation
fix: restore local listing and Aspire tracing - #1505
Merged
Merged
Conversation
BenjaminMichaelis
changed the title
The 9.0.21 pin caused NU1605 (Pkcs 10.0.12 -> 9.0.21 downgrade via Cryptography.Xml) when 'dotnet ef migrations bundle' restored for linux-x64, failing the Docker build.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The listing and telemetry changes are coherent, deterministic, and adequately validated.
0 open findings
What changed in this PR
Restores BookContent listing discovery and ensures Aspire OTLP tracing takes precedence over Azure Monitor.
Changes:
- Supports legacy and BookContent listing filenames, preferring C# sources.
- Prioritizes OTLP export when configured.
- Adds regression coverage, cryptography dependencies, and TUnit guidance.
| File | Description |
|---|---|
ListingSourceCodeService.cs |
Expands filename matching and deterministic source selection. |
Program.cs |
Prioritizes OTLP over Azure Monitor. |
EssentialCSharp.Web.csproj |
Adds the PKCS dependency. |
ListingSourceCodeServiceTests.cs |
Tests BookContent filename discovery. |
Listing99.01.Sample.cs |
Provides BookContent-style test data. |
EssentialCSharp.Web.Tests.csproj |
Adds the XML cryptography dependency. |
Directory.Packages.props |
Centrally versions cryptography packages. |
.claude/skills/tunit/SKILL.md |
Adds TUnit guidance for Claude agents. |
.agents/skills/tunit/SKILL.md |
Adds TUnit guidance for general agents. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Listing01.01.HelloWorldInC#.cswhen serving listing source; prefer C# files while retaining legacy filenames.OTEL_EXPORTER_OTLP_ENDPOINTis configured, and use Azure Monitor only when OTLP is not configured. This keeps local Aspire traces visible even when an App Insights connection string is also configured.Validation
traceparent, Web listing API span, and Try.NET/commandsspans shared trace IDb04906a9bfd84ca0839f6d807e82b107.