Skip to content

Commit 864246c

Browse files
committed
chore(php-cs-fixer): disable php_unit_strict in favor of Rector
php_unit_strict rewrites assertEquals->assertSame for objects and arrays too, breaking value comparisons. Rector's AssertEqualsToSameRector only converts provably-scalar assertions, so it is the safer place for this.
1 parent 1b35829 commit 864246c

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎IxDFCodingStandard/PhpCsFixer/Rules.php‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,9 @@ public static function get(): array
125125
'php_unit_method_casing' => ['case' => 'snake_case'],
126126
'php_unit_no_expectation_annotation' => true, // risky
127127
'php_unit_set_up_tear_down_visibility' => true, // risky
128-
'php_unit_strict' => true, // risky
128+
// Delegated to Rector's AssertEqualsToSameRector, which only rewrites provably-scalar assertions;
129+
// this fixer converts assertEquals→assertSame for objects/arrays too, breaking value comparisons.
130+
'php_unit_strict' => false,
129131
'php_unit_test_annotation' => ['style' => 'annotation'], // risky
130132
'phpdoc_align' => ['align' => 'left'],
131133
'phpdoc_array_type' => true, // risky

0 commit comments

Comments
 (0)