Review remarks

Author: carbolymer

cardano-rpc/src/Cardano/Rpc/Server/Internal/UtxoRpc/Type/Tx.hs

@@ -217,12 +217,13 @@ txToUtxoRpcTx ledgerTx = anyEraTxConstraints sbe $ do
         ShelleyBasedEraBabbage -> []
         ShelleyBasedEraConway -> conwayOnwardsProposals
         ShelleyBasedEraDijkstra -> conwayOnwardsProposals
-      conwayOnwardsProposals
-        :: L.ConwayEraPParams (ShelleyLedgerEra era)
-        => [Proto UtxoRpc.GovernanceActionProposal]
-      conwayOnwardsProposals =
-        maybe [] (map proposalProcedureToUtxoRpcProposal . toList) $
-          body ^. L.proposalProceduresTxBodyG
+       where
+        conwayOnwardsProposals
+          :: L.ConwayEraPParams (ShelleyLedgerEra era)
+          => [Proto UtxoRpc.GovernanceActionProposal]
+        conwayOnwardsProposals =
+          maybe [] (map proposalProcedureToUtxoRpcProposal . toList) $
+            body ^. L.proposalProceduresTxBodyG
   defMessage
     & U5c.hash .~ serialiseToRawBytes (fromShelleyTxId (L.txIdTx ledgerTx))
     & U5c.inputs .~ inputs

cardano-rpc/test/cardano-rpc-test/Test/Cardano/Rpc/FetchBlockTx.hs

@@ -53,7 +53,7 @@ import Test.Tasty.Hedgehog (testPropertyNamed)
 -- use it, so a new stable era only needs updating here; the era-specific
 -- constructors in those properties then fail to compile until adjusted.
 latestStableEra :: Exp.Era ConwayEra
-latestStableEra = Exp.ConwayEra
+latestStableEra = Exp.useEra
 
 -- | One-way projection property for 'txToUtxoRpcTx': there is no inverse
 -- conversion, so the proto message and the ledger transaction are projected