Move EraBasedProtocolParametersUpdate to Cardano.Api.Compatible.ProtocolParametersUpdate - #1336
Open
Jimbo4350 wants to merge 1 commit into
Open
Move EraBasedProtocolParametersUpdate to Cardano.Api.Compatible.ProtocolParametersUpdate#1336Jimbo4350 wants to merge 1 commit into
Jimbo4350 wants to merge 1 commit into
Conversation
Jimbo4350
requested review from
CarlosLopezDeLara,
carbolymer,
disassembler,
erikd and
palas
as code owners
September 10, 2026 16:49
Jimbo4350
force-pushed
the
jordan/move-era-based-pparams-update
branch
from
September 10, 2026 16:49
a4fad03 to
302fc0d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| {-# LANGUAGE ConstraintKinds #-} | ||
| {-# LANGUAGE DataKinds #-} | ||
| {-# LANGUAGE DeriveAnyClass #-} | ||
| {-# LANGUAGE DeriveDataTypeable #-} |
| {-# LANGUAGE DataKinds #-} | ||
| {-# LANGUAGE DeriveAnyClass #-} | ||
| {-# LANGUAGE DeriveDataTypeable #-} | ||
| {-# LANGUAGE DeriveGeneric #-} |
| {-# LANGUAGE FlexibleContexts #-} | ||
| {-# LANGUAGE FlexibleInstances #-} | ||
| {-# LANGUAGE GADTs #-} | ||
| {-# LANGUAGE GeneralizedNewtypeDeriving #-} |
| {-# LANGUAGE FlexibleInstances #-} | ||
| {-# LANGUAGE GADTs #-} | ||
| {-# LANGUAGE GeneralizedNewtypeDeriving #-} | ||
| {-# LANGUAGE LambdaCase #-} |
| {-# LANGUAGE GADTs #-} | ||
| {-# LANGUAGE GeneralizedNewtypeDeriving #-} | ||
| {-# LANGUAGE LambdaCase #-} | ||
| {-# LANGUAGE NamedFieldPuns #-} |
…colParametersUpdate Relocates the era-based protocol parameter update GADT, its era-sliced record types, createEraBasedProtocolParamUpdate, createPParams and the pre-Conway UpdateProposal machinery into a new Compatible module. The UpdateProposal cluster has to move with the GADT: UpdateProposal contains it, and its FromCBOR instance depends on fromLedgerPParamsUpdate, which in turn uses the private pparamsUpdateTo* helpers. Cardano.Api.ProtocolParameters re-exports the new module, so its export list and Cardano.Api are unchanged. Cardano.Api.Compatible re-exports the new module as well.
Jimbo4350
force-pushed
the
jordan/move-era-based-pparams-update
branch
from
September 10, 2026 17:58
302fc0d to
1f1acd6
Compare
Base automatically changed from
jordan/remove-protocol-parameters
to
master
September 10, 2026 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Follow-up to #1335 (stacked on it). Moves the era-based update-proposal machinery out of
Cardano.Api.ProtocolParametersintoCardano.Api.Compatible.ProtocolParametersUpdate:EraBasedProtocolParametersUpdate, its era-sliced records,createEraBasedProtocolParamUpdate,createPParams,UpdateProposaland itsto/fromLedger*conversions. TheUpdateProposalcluster must move with the GADT: it contains it, and the GADT'sFromCBORinstance depends onfromLedgerPParamsUpdate, which uses the private slice helpers.Cardano.Api.ProtocolParametersre-exports the new module, so its export list andCardano.Apiare unchanged.Cardano.Api.Compatiblere-exports it too.How to trust this PR
Cardano.Api.ProtocolParametersis identical to master.cabal build cardano-api --enable-testsis clean under-Werror.Checklist
🤖 Generated with Claude Code