EI-2938 remove keys - #69
Open
andyantrim wants to merge 7 commits into
Open
Conversation
added 6 commits
June 4, 2024 14:31
conbon
reviewed
Jun 6, 2024
conbon
reviewed
Jun 6, 2024
|
|
||
| _, _, err = advancedapi.CreateDelegationProof(delegatingIssuer, subjectDoc, test.ValidKeyPairPlop) | ||
| assert.ErrorContains(t, err, "unable to find public key in document matching key pair secrets") | ||
| assert.NilError(t, err) |
Author
There was a problem hiding this comment.
@StephanieBracaloni input on this test case? Should a delegation with a revoked key still be able to create a proof?
conbon
reviewed
Jun 6, 2024
conbon
reviewed
Jun 6, 2024
conbon
reviewed
Jun 7, 2024
conbon
reviewed
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add client library checks that ensure a key is not removed, but still allow the key to be revoked.